0009694: Added size column in the server list #154
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds a new column to the server list that displays the total size of all currently loaded resources on the server
|
anyone? |
qaisjp
reviewed
Jul 1, 2018
| const SString strPingSortKey = SString ( "%04d-", pServer->nPing ) + pServer->strTieBreakSortKey; | ||
|
|
||
| const SString strResSize = GetDataUnit(static_cast < unsigned long long > ( pServer->fResSize * 1024 ) ); | ||
| const SString strResSizeSortKey = SString ( "-", 0 ) + pServer->strTieBreakSortKey; // TODO |
|
I think, this could be in mta even show incorrect value ( due part of files is already downloaded ) |
|
It should display the download size that will actually occur. Otherwise I think this feature will generate complaints |
|
Thanks for your pull request! Unfortunately we can't merge this as it does not accurately show the correct download size. |
patrikjuvonen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an a little bit ugly realization of #9694: adds a new column to the server list that displays the total size of all currently loaded resources on the server.
TODO: sorting in this column
Screenshot: