Move version.h and build_overrides.h under Shared folder #1956
Conversation
| // | ||
| // To compile a client: | ||
| // 1. set MTASA_VERSION_TYPE to VERSION_TYPE_CUSTOM | ||
| // 2. Use netc.dll from the latest unstable build (nightly.mtasa.com) |
There was a problem hiding this comment.
This comment looks wrong.. the netc.dll made for custom builds (from install-data.bat), which is located at https://mirror.mtasa.com/bdata/netc.dll, should be used.
There was a problem hiding this comment.
That's the current comment on master (https://github.com/multitheftauto/mtasa-blue/blob/master/Client/version.h#L10)
What would be an accurate fix?
| // 2. Use netc.dll from the latest unstable build (nightly.mtasa.com) | |
| // 2. Run install-data for netc.dll |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
@Dutchman101 Any comment on this?
There was a problem hiding this comment.
To correct the existing comment(s) that are incorrect.. either in this PR or a new one. Like just refer to the existing build instructions or install-data without specific mention of netc. I would suggest to just refer to the build instructions readme.
Only ccw can merge this
Work done by @qaisjp, moved build_overrides.h under Shared as well as suggested by @ccw808.
As they have minimal differences this makes maintaining easier to have the contents shared between client and server.
Only @ccw808 can merge because this requires build server modifications to support the new build_overrides.h filepath.