Skip to content

Conversation

@TFP-dev
Copy link
Contributor

@TFP-dev TFP-dev commented Oct 20, 2022

This function will reinit 3D markers. This can be useful if you want to replace marker 3D model. Fixes closed issue #2213.

API:
engineReinitMarkers()

Test resource:
This resource replaces "arrow" marker and adds command reinitMarkers.
marker_test_resource.zip

Screenshot:
comp

@lopezloo lopezloo added the enhancement New feature or request label Oct 20, 2022
@CrosRoad95
Copy link

CrosRoad95 commented Oct 22, 2022

". This can be useful if you want to replace marker 3D model."
so, make if you replace 3d model of marker -> call "engineReinitMarkers", we don't use "reinitVehicles", "reinitObjects" ect after element will be replaced

@TFP-dev
Copy link
Contributor Author

TFP-dev commented Oct 22, 2022

". This can be useful if you want to replace marker 3D model." so, make if you replace 3d model of marker -> call "engineReinitMarkers", we don't use "reinitVehicles", "reinitObjects" ect after element will be replaced

But we use engineRestreamWorld. Currently servers can use fact that you can't replace marker model so engineReinitMarkers is backwards compatible.

@CrosRoad95
Copy link

you actually fixing a bug, everyone will happy if suddenly markers will work as intended

@TFP-dev
Copy link
Contributor Author

TFP-dev commented Oct 22, 2022

you actually fixing a bug, everyone will happy if suddenly markers will work as intended

Check issue #2213

Copy link
Member

@sbx320 sbx320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be more useful to apply this whenever we replac a marker model? That way scripters wouldn't need to work around it.

@TFP-dev
Copy link
Contributor Author

TFP-dev commented Oct 24, 2022

Wouldn't it be more useful to apply this whenever we replac a marker model? That way scripters wouldn't need to work around it.

Currently you can use fact that you can't replace markers, for example you can replace id 1559 with the building model and use it instead of allocating new model id with engineRequestModel and markers will stay intact.

sbx320
sbx320 previously requested changes Oct 24, 2022
Copy link
Member

@sbx320 sbx320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments regarding argparser usage

@lopezloo
Copy link
Member

Wouldn't it be more useful to apply this whenever we replac a marker model? That way scripters wouldn't need to work around it.

Maybe that could be implemented and documented as 1.6 backwards incompatible change.

@TFP-dev TFP-dev mentioned this pull request Jun 8, 2023
@botder
Copy link
Member

botder commented Sep 19, 2023

Superseded by pull request #3059.

@botder botder closed this Sep 19, 2023
@botder botder removed this from the 1.6.1 milestone Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants