-
-
Notifications
You must be signed in to change notification settings - Fork 496
Add engineReinitMarkers() #2794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
". This can be useful if you want to replace marker 3D model." |
But we use |
|
you actually fixing a bug, everyone will happy if suddenly markers will work as intended |
Check issue #2213 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be more useful to apply this whenever we replac a marker model? That way scripters wouldn't need to work around it.
Currently you can use fact that you can't replace markers, for example you can replace id 1559 with the building model and use it instead of allocating new model id with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments regarding argparser usage
Maybe that could be implemented and documented as 1.6 backwards incompatible change. |
|
Superseded by pull request #3059. |
This function will reinit 3D markers. This can be useful if you want to replace marker 3D model. Fixes closed issue #2213.
API:
engineReinitMarkers()Test resource:
This resource replaces "arrow" marker and adds command
reinitMarkers.marker_test_resource.zip
Screenshot:
