Skip to content

Conversation

@Proxy-99
Copy link
Contributor

@Proxy-99 Proxy-99 commented Jun 30, 2024

add client function to set VolumetricShadows and IsVolumetricShadowsEnabled()
setVolumetricShadowsEnabled(true)
isVolumetricShadowsEnabled()
resetVolumetricShadows() will be reset to video game setting
#2248

test
https://youtu.be/E_Tl5meniEc?si=ERiqJeXRPrdpU2Xf

@tederis tederis added the enhancement New feature or request label Jul 1, 2024
@Proxy-99 Proxy-99 marked this pull request as draft July 1, 2024 14:57
@Proxy-99
Copy link
Contributor Author

Proxy-99 commented Jul 1, 2024

I have added new function IsVolumetricShadowsEnabled()

@Proxy-99 Proxy-99 marked this pull request as ready for review July 1, 2024 17:04
@Proxy-99 Proxy-99 requested review from FileEX and Nico8340 July 1, 2024 17:04
static std::variant<bool, float, CLuaMultiReturn<float, float, float>> GetWorldProperty(eWorldProperty property);
static bool SetWorldProperty(eWorldProperty property, float arg1, std::optional<float> arg2, std::optional<float> arg3);
static bool ResetWorldProperty(eWorldProperty property);
static bool SetVolumetricShadowsEnabled(bool enable) noexcept;
Copy link
Contributor

@TracerDS TracerDS Jul 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any void type lua functions? How would that work here?

@Xenius97
Copy link
Contributor

Xenius97 commented Jul 1, 2024

Resolves #2777 too, or is this a different shadow-type?

@Proxy-99
Copy link
Contributor Author

Proxy-99 commented Jul 2, 2024

Resolves #2777 too, or is this a different shadow-type?

This is only for volumetricShadowes setting but
Later on I will add the functions for ped dynamic shadows too in another pull request

@Proxy-99 Proxy-99 requested a review from TracerDS July 2, 2024 16:49
@Proxy-99 Proxy-99 requested a review from tederis July 3, 2024 12:36
Copy link
Member

@Nico8340 Nico8340 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Proxy-99 Proxy-99 requested a review from TracerDS August 19, 2024 12:44
@Proxy-99 Proxy-99 requested a review from TracerDS September 5, 2024 14:22
@Proxy-99
Copy link
Contributor Author

Proxy-99 commented Sep 5, 2024

I added function resetVolumetricShadows() @tederis @TracerDS hope all good now.

Copy link
Member

@tederis tederis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. PR is mature enough, reviewed by several peoples and thus ready to merge.

@tederis tederis merged commit 6c93a49 into multitheftauto:master Sep 5, 2024
MTABot pushed a commit that referenced this pull request Sep 5, 2024
6c93a49 Add setVolumetricShadowsEnabled function (#3528)
80b5adf Update client en_US pot
@CrosRoad95
Copy link

it should be "areVolumetricShadowsEnabled", not "isVolumetricShadowsEnabled" since "shadows" is a plural noun ;), now, i may think that this function accept "Element" at first argument, but it doesn't.

@Proxy-99
Copy link
Contributor Author

it should be "areVolumetricShadowsEnabled", not "isVolumetricShadowsEnabled" since "shadows" is a plural noun ;), now, i may think that this function accept "Element" at first argument, but it doesn't.

could be are but are rarely used, but is looks way familiar, I do not know really if that worth change it also there is no such thing as disabled shadows per element. @CrosRoad95

@CrosRoad95
Copy link

areVehicleLightsOn - plural, noun
areTrafficLightsLocked - plural, noun
but isVolumetricShadowsEnabled ???

@botder botder added this to the 1.6.1 milestone Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants