-
-
Notifications
You must be signed in to change notification settings - Fork 503
Add setVolumetricShadowsEnabled function #3528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I have added new function IsVolumetricShadowsEnabled() |
| static std::variant<bool, float, CLuaMultiReturn<float, float, float>> GetWorldProperty(eWorldProperty property); | ||
| static bool SetWorldProperty(eWorldProperty property, float arg1, std::optional<float> arg2, std::optional<float> arg3); | ||
| static bool ResetWorldProperty(eWorldProperty property); | ||
| static bool SetVolumetricShadowsEnabled(bool enable) noexcept; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have any void type lua functions? How would that work here?
|
Resolves #2777 too, or is this a different shadow-type? |
This is only for volumetricShadowes setting but |
Nico8340
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This reverts commit d026afc.
adding resetVolumetricShadows() function
tederis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. PR is mature enough, reviewed by several peoples and thus ready to merge.
|
it should be "areVolumetricShadowsEnabled", not "isVolumetricShadowsEnabled" since "shadows" is a plural noun ;), now, i may think that this function accept "Element" at first argument, but it doesn't. |
could be |
|
areVehicleLightsOn - plural, noun |
add client function to set VolumetricShadows and IsVolumetricShadowsEnabled()
setVolumetricShadowsEnabled(true)isVolumetricShadowsEnabled()resetVolumetricShadows()will be reset to video game setting#2248
test
https://youtu.be/E_Tl5meniEc?si=ERiqJeXRPrdpU2Xf