Adds new timer functions #3683
Merged
Adds new timer functions #3683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- pauseTimer - isTimerPaused
TracerDS
suggested changes
Aug 27, 2024
Member
|
setTimerPaused is the better name I think. |
tederis
reviewed
Aug 27, 2024
Contributor
Author
I thought so too, but i thought other people would think that sounded too weird. I'll change it later when im doing all of the other changes |
Member
If you wish to use |
TracerDS
suggested changes
Aug 27, 2024
TracerDS
approved these changes
Aug 28, 2024
tederis
reviewed
Aug 28, 2024
tederis
approved these changes
Aug 28, 2024
Member
tederis
left a comment
tederis
left a comment
There was a problem hiding this comment.
Looks good. And since it overcome several reviews ready to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just practicing and this is something I thought of, surprised it's not already implemented.
bool pauseTimer(timer theTimer, bool paused)bool setTimerPaused(timer theTimer, bool paused)-- Setting paused to true pauses the timer, while false resumes it.bool isTimerPaused(timer theTimer)-- returns true if paused