Refactor server side CVehicleNames.cpp #3800
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vehicles with two names: Vehicles with alternative names are listed in order. For example, “Sadler Damaged”, the “Sadler” row has both the damaged version and the normal version names. and The vehicle names are organized alphabetically so that they can be used consistently in the same order on both server and client side. (the confusion in the table has been eliminated by sorting the server and client side from a to z)
|
You duplicate #3799 |
Contributor
Author
one for client and one for server; |
Contributor
|
You should merge the other PR to this one, and rename the PR to what issue it resolves |
Contributor
|
Isn't this going to break things horribly? You changed the list from 400-611 to alphabetical but changed nothing else |
Contributor
|
Please add the info about changing the server version of files as per #3800 (comment) |
shadylua
changed the title
|
It's easier for you to merge the other one into this one and rename it, so it would be more organized. |
Member
|
It breaks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vehicles with two names: Vehicles with alternative names are listed in order. For example, “Sadler Damaged”, the “Sadler” row has both the damaged version and the normal version names. and The vehicle names are organized alphabetically so that they can be used consistently in the same order on both server and client side. (the confusion in the table has been eliminated by sorting the server and client side from a to z)