Other fixes for #3848 #3900
Merged
Other fixes for #3848 #3900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tederis
approved these changes
Dec 23, 2024
Member
tederis
left a comment
tederis
left a comment
There was a problem hiding this comment.
I'm going to merge it faster than normal because this PR fixes the assertation problem described here: c0376c9#r150652050.
Contributor
Author
|
If a problem is found, write here, I will fix it as soon as possible. |
tederis
pushed a commit
that referenced
this pull request
Dec 25, 2024
| CHandlingEntry* pEntry = pVehicle->GetHandlingData(); | ||
|
|
||
| lua_newtable(luaVM); | ||
| if (const auto* const entry = pVehicle->GetHandlingData()) |
Member
There was a problem hiding this comment.
Should never happen. Handling is just broken after this chain of PR's
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are bug fixes and what was not implemented that was in the plans