Refactor CLuaTeamDefs (client) #3944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tederis
reviewed
Jan 10, 2025
tederis
reviewed
Jan 10, 2025
tederis
previously approved these changes
Jan 10, 2025
tederis
reviewed
Jan 10, 2025
tederis
previously approved these changes
Jan 10, 2025
botder
reviewed
Jan 10, 2025
botder
approved these changes
Jan 10, 2025
botder
requested changes
Jan 10, 2025
botder
approved these changes
Jan 10, 2025
MTABot
pushed a commit
that referenced
this pull request
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request refactors the CLuaTeamDefs class on the client side, all functions use the new argument parser, Hungarian notation has been removed, and a wrong Lua class that was probably left in by accident has been removed as well.