Server side getColPolygonHeight fix #3946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheNormalnij
approved these changes
Jan 10, 2025
TheNormalnij
added
the
backwards-incompatible
Member
|
Nice catch! |
- pauseTimer - isTimerPaused
tederis
force-pushed
the
GetColPolygonHeight_fix
branch
from
3f3520c to
7a29cac
Compare
Nico8340
approved these changes
Jan 10, 2025
botder
approved these changes
Jan 10, 2025
Member
|
I made a mistake here, should've merged this after 1.6.1 release. |
Member
|
As this was reverted, it can now be re-introduced for 1.7 release, so anyone feel free to make a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the return type of server side
getColPolygonHeight. Currently it returns a table, whereas two floats are expected.Additional info: #3537 (comment)