Fixes #551 - onMarkerHit on attached elements
#4571
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #551
Notes
observed the debug line
ERROR: FIXME: CRPCFunctions::ProcessPacket - Element doesn't exist on client (AttachElements)when the attach RPC arrives on the client before the marker is fully created. This is just a timing/diagnostic warning and does not affect marker hits. It could be silenced by wrapping that log in an if that skipsATTACH_ELEMENTS/DETACH_ELEMENTSYou can just use a
Timer: