Skip to content

Conversation

@omar-o22
Copy link
Contributor

This PR removes useless checkbox from options

@omar-o22 omar-o22 requested a review from jlillis as a code owner August 29, 2025 23:42
@PerikiyoXD
Copy link

PerikiyoXD commented Aug 30, 2025

@PerikiyoXD
Copy link

PerikiyoXD commented Aug 30, 2025

mybad, indeed it's useless per-safety reasons:
https://wiki.multitheftauto.com/wiki/Serial

Caution

Note: NEVER use serials for anything too critical (like handling admin rights, or automatically logging in) as they can't be guaranteed to be unique or non-fakable.

@Nico8340
Copy link
Member

Please delete autologin.xml and remove it from admin as well

@PrimelPrime
Copy link
Contributor

Isn't admin2 an unfinished resource? It does not have any purpose at the moment but the functionality could be extended instead of removing it. I dont know the state of admin2 tho

@PerikiyoXD
Copy link

Isn't admin2 an unfinished resource? It does not have any purpose at the moment but the functionality could be extended instead of removing it. I dont know the state of admin2 tho

I thought the same until you actually read.

mybad, indeed it's useless per-safety reasons:
https://wiki.multitheftauto.com/wiki/Serial

Caution

Note: NEVER use serials for anything too critical (like handling admin rights, or automatically logging in) as they can't be guaranteed to be unique or non-fakable.

@omar-o22
Copy link
Contributor Author

Please delete autologin.xml and remove it from admin as well

Oh i forgot to delete it btw it's not actually used inside the resource, it's just a leftover file

@PrimelPrime
Copy link
Contributor

Isn't admin2 an unfinished resource? It does not have any purpose at the moment but the functionality could be extended instead of removing it. I dont know the state of admin2 tho

I thought the same until you actually read.

mybad, indeed it's useless per-safety reasons:
https://wiki.multitheftauto.com/wiki/Serial

Caution

Note: NEVER use serials for anything too critical (like handling admin rights, or automatically logging in) as they can't be guaranteed to be unique or non-fakable.

Could make use of discord rpc here instead

@omar-o22
Copy link
Contributor Author

omar-o22 commented Aug 30, 2025

Do you mean discord id? umm maybe no, never trust any data coming from client, there's no way to get discord id from server-side that means u need to use getDiscordRichPresenceUserID on client side then send it using triggerServerEvent that means the cheater can edit/modify the trigger

Copy link
Contributor

@jlillis jlillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. It does not appear this feature was ever actually implemented in admin or admin2.

@omar-o22 omar-o22 changed the title admin2: Remove useless checkbox admin/admin2: Remove useless checkbox Sep 1, 2025
@omar-o22 omar-o22 requested review from Nico8340 and jlillis September 1, 2025 01:45
@ArranTuna ArranTuna merged commit dc02545 into multitheftauto:master Sep 17, 2025
1 check passed
@omar-o22 omar-o22 deleted the Remove-useless-button branch September 26, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants