-
-
Notifications
You must be signed in to change notification settings - Fork 172
admin/admin2: Remove useless checkbox #672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
admin/admin2: Remove useless checkbox #672
Conversation
|
mybad, indeed it's useless per-safety reasons: Caution Note: NEVER use serials for anything too critical (like handling admin rights, or automatically logging in) as they can't be guaranteed to be unique or non-fakable. |
|
Please delete autologin.xml and remove it from admin as well |
|
Isn't admin2 an unfinished resource? It does not have any purpose at the moment but the functionality could be extended instead of removing it. I dont know the state of admin2 tho |
I thought the same until you actually read.
Caution Note: NEVER use serials for anything too critical (like handling admin rights, or automatically logging in) as they can't be guaranteed to be unique or non-fakable. |
Oh i forgot to delete it btw it's not actually used inside the resource, it's just a leftover file |
Could make use of discord rpc here instead |
|
Do you mean discord id? umm maybe no, never trust any data coming from client, there's no way to get discord id from server-side that means u need to use getDiscordRichPresenceUserID on client side then send it using triggerServerEvent that means the cheater can edit/modify the trigger |
jlillis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. It does not appear this feature was ever actually implemented in admin or admin2.
This PR removes useless checkbox from options