-
Notifications
You must be signed in to change notification settings - Fork 152
Updated sdk-dapp documentation to v.5 #1060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreibancioiu
approved these changes
Jul 15, 2025
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the sdk-dapp documentation to reflect version 5.0.0, expands framework support, and overhauls usage and internal structure guides.
- Bumped version references and requirements to v5.0.0
- Expanded supported frameworks and live demo links
- Reorganized usage, internal structure, and debugging sections with new code examples
Comments suppressed due to low confidence (3)
docs/sdk-and-tools/sdk-dapp/sdk-dapp.md:444
- The word
controllesis misspelled; it should becontrollers.
- Last are the UI components hosted in [@multiversx/sdk-dapp-ui](https://github.com/multiversx/mx-sdk-dapp-ui) with some components controlled on demand by classes defined in `controlles` and `managers`
docs/sdk-and-tools/sdk-dapp/sdk-dapp.md:700
- The word
consitstis misspelled; it should beconsist.
`sdk-dapp` needs to make use of visual elements for allowing the user to interact with some providers (like the ledger), or to display messages to the user (like idle states or toasts). These visual elements consitst of webcomponents hosted in the `@multiversx/sdk-dapp-ui` package. Thus, `sdk-dapp` does not hold any UI elements, just business logic that controls external components. We can consider two types of UI components: internal and public. They are differentiated by the way they are controlled: internal components are controlled by `sdk-dapp`'s signing or logging in flows, while public components should be controlled by the dApp.
docs/sdk-and-tools/sdk-dapp/sdk-dapp.md:592
- The type
SigendTransactionTypeis misspelled; it should beSignedTransactionType.
const parallelTransactions: SigendTransactionType[] = [tx1, tx2, tx3, tx4];
andreigiura
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added sdk-dapp-core documentation
Did you test the changes locally ?
Which category (categories) does this pull request belong to?