Skip to content

Conversation

@arhtudormorar
Copy link
Contributor

Added sdk-dapp-core documentation

Did you test the changes locally ?

  • yes
  • no

Which category (categories) does this pull request belong to?

  • document new feature
  • update documentation that is not relevant anymore
  • add examples or more information about a component
  • fix grammar issues
  • other

@arhtudormorar arhtudormorar changed the title Added sdk-dapp-core documentation Updated sdk-dapp documentation to v.5 Jul 14, 2025
@arhtudormorar arhtudormorar marked this pull request as ready for review July 14, 2025 12:05
@andreibancioiu andreibancioiu requested a review from Copilot July 15, 2025 07:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the sdk-dapp documentation to reflect version 5.0.0, expands framework support, and overhauls usage and internal structure guides.

  • Bumped version references and requirements to v5.0.0
  • Expanded supported frameworks and live demo links
  • Reorganized usage, internal structure, and debugging sections with new code examples
Comments suppressed due to low confidence (3)

docs/sdk-and-tools/sdk-dapp/sdk-dapp.md:444

  • The word controlles is misspelled; it should be controllers.
- Last are the UI components hosted in [@multiversx/sdk-dapp-ui](https://github.com/multiversx/mx-sdk-dapp-ui) with some components controlled on demand by classes defined in `controlles` and `managers`

docs/sdk-and-tools/sdk-dapp/sdk-dapp.md:700

  • The word consitst is misspelled; it should be consist.
`sdk-dapp` needs to make use of visual elements for allowing the user to interact with some providers (like the ledger), or to display messages to the user (like idle states or toasts). These visual elements consitst of webcomponents hosted in the `@multiversx/sdk-dapp-ui` package. Thus, `sdk-dapp` does not hold any UI elements, just business logic that controls external components. We can consider two types of UI components: internal and public. They are differentiated by the way they are controlled: internal components are controlled by `sdk-dapp`'s signing or logging in flows, while public components should be controlled by the dApp.

docs/sdk-and-tools/sdk-dapp/sdk-dapp.md:592

  • The type SigendTransactionType is misspelled; it should be SignedTransactionType.
const parallelTransactions: SigendTransactionType[] = [tx1, tx2, tx3, tx4];

@arhtudormorar arhtudormorar merged commit d1fa296 into main Jul 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants