-
Notifications
You must be signed in to change notification settings - Fork 152
Tool 655 update cookbooks #1135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the documentation to reflect the transition from SDK v13/v14 to newer versions across the JavaScript and Python SDKs. The changes primarily involve version updates, reference corrections, and removal of legacy documentation.
- Updates JavaScript SDK cookbook references from v13 to v14
- Updates Python SDK documentation from v1 to v2 throughout
- Removes the legacy v13 JavaScript SDK cookbook entirely
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sidebars.js | Updates navigation to reference v14 instead of v13 JavaScript SDK cookbook |
| docs/sdk-and-tools/sdk-py.md | Updates Python SDK version references from v1 to v2 and adds gas limit estimation documentation |
| docs/sdk-and-tools/sdk-js/sdk-js-cookbook-v14.md | Corrects document ID and pagination references for v14 cookbook |
| docs/sdk-and-tools/sdk-js/sdk-js-cookbook-v13.md | Removes entire legacy v13 cookbook documentation |
| docs/developers/relayed-transactions.md | Updates JavaScript SDK reference from v14 to v15 |
| - [sdk-py support](/sdk-and-tools/sdk-py/#relayed-transactions) | ||
| - [sdk-js v14 support](/sdk-and-tools/sdk-js/sdk-js-cookbook#relayed-transactions) | ||
| - [sdk-js v13 support (legacy)](/sdk-and-tools/sdk-js/sdk-js-cookbook-v13#preparing-a-relayed-transaction) | ||
| - [sdk-js v15 support](/sdk-and-tools/sdk-js/sdk-js-cookbook#relayed-transactions) |
Copilot
AI
Jul 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reference is being updated to v15, but the actual cookbook file being updated in this PR is v14. This creates a potential inconsistency - either the reference should point to v14 or there should be a v15 cookbook file.
| - [sdk-js v15 support](/sdk-and-tools/sdk-js/sdk-js-cookbook#relayed-transactions) | |
| - [sdk-js v14 support](/sdk-and-tools/sdk-js/sdk-js-cookbook#relayed-transactions) |
| @@ -1,7 +1,7 @@ | |||
| --- | |||
| id: sdk-js-cookbook | |||
| id: sdk-js-cookbook-v14 | |||
Copilot
AI
Jul 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The document ID is changed to 'sdk-js-cookbook-v14', but the sidebar configuration in sidebars.js still references 'sdk-js-cookbook-v14' as an item. Ensure this ID matches the sidebar reference for proper navigation.
andreibancioiu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could have kept v13 for a little bit longer, I think 🙈 🤞
Description of the pull request (what is new / what has changed)
Did you test the changes locally ?
Which category (categories) does this pull request belong to?