Breaking change: unifying provider interfaces, preparing network providers for extraction - step 1 #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreibancioiu
changed the title
| return ( | ||
| this.status == "received" || | ||
| this.status == "pending" || | ||
| this.status == "partially-executed" |
There was a problem hiding this comment.
can we have status partially-executed? I cannot find it here:
https://github.com/ElrondNetwork/elrond-go-core/blob/main/data/transaction/status.go
and I can only find it in a unit test on elrond-proxy-go
There was a problem hiding this comment.
Indeed, old, deprecated status 🙏
bogdan-rosianu
approved these changes
Apr 6, 2022
ccorcoveanu
approved these changes
Apr 6, 2022
andreibancioiu
added a commit
that referenced
this pull request
Sep 25, 2024
Breaking change: unifying provider interfaces, preparing network providers for extraction - step 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of decoupling
src/networkProviderfrom erdjs components.When decoupling is done, no file within
src/networkProvidershould reference files from other packages. Then, we can extractnetworkProviderto a separate repository and continue the interface reconciliation process (API & Proxy).