Skip to content

[Regression] When loading the ABI, sort custom types by their type dependencies. #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andreibancioiu merged 3 commits into from
May 3, 2022
Merged

[Regression] When loading the ABI, sort custom types by their type dependencies. #208

andreibancioiu merged 3 commits into from
May 3, 2022

Conversation

@andreibancioiu
Copy link
Contributor

@andreibancioiu andreibancioiu commented May 3, 2022 •
edited
Loading

  • Define Type.getNamesOfDependencies()
  • When loading the ABI, sort custom types by their type dependencies (if B depends on A, then A precedes B).

@andreibancioiu andreibancioiu self-assigned this May 3, 2022
@andreibancioiu andreibancioiu changed the title Fix abi order When loading the ABI, sort custom types by their type dependencies. May 3, 2022
@andreibancioiu andreibancioiu changed the title When loading the ABI, sort custom types by their type dependencies. [Regression] When loading the ABI, sort custom types by their type dependencies. May 3, 2022
@andreibancioiu andreibancioiu merged commit 8a213ed into main May 3, 2022
@andreibancioiu andreibancioiu deleted the fix-abi-order branch May 3, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bogdan-rosianu bogdan-rosianu bogdan-rosianu approved these changes

+1 more reviewer

@claudiu725 claudiu725 claudiu725 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@andreibancioiu andreibancioiu

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andreibancioiu @claudiu725 @bogdan-rosianu