Fix sort custom types abi #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 12, 2022 21:12
… version of sortCustomTypesByDependencies
ccorcoveanu
requested changes
Aug 1, 2022
Contributor
ccorcoveanu
left a comment
ccorcoveanu
left a comment
There was a problem hiding this comment.
I actually like customTypes as private better, because it is anyway altered using sort. But unfortunately this is a breaking change.
So, I prepared a new branch feat/erdjs-v12. Could you please point the PR there, and add a changelog entry with a short description about this breaking change, linked to the PR?
We will release this with erdjs v12.
ccorcoveanu
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I implemented topological sort to be sure to sort all the custom types in a good way. I also changed the data test to a not handled case by the previous sort.
I had to change the attribute customTypes from readonly to private. But we can add a getter if needed, even if some getters are already provided to get specific enums or structs.
If the readonly is mandatory I can just implement the all thing in a different way.