Clean up testcase for relayedTransactionV2Builder #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the sender is overwritten anyways it doesn't matter much, but it's confusing for people wanting to learn about the relayedTransactionV2Builder :)
bogdan-rosianu
previously approved these changes
Oct 10, 2022
Contributor
bogdan-rosianu
left a comment
bogdan-rosianu
left a comment
There was a problem hiding this comment.
Yup, thanks for your contribution ! 💯
schimih
previously approved these changes
Oct 10, 2022
Contributor
|
Can you push again after regenerating the package-lock? You need node |
Contributor
Author
|
@bogdan-rosianu |
Contributor
|
package-lock check is still failing |
andreibancioiu
approved these changes
Oct 12, 2022
bogdan-rosianu
approved these changes
Oct 12, 2022
Merged
Contributor
|
Thanks for the finding! I will close this PR as it has been re-done in #244 (with signed commits and proper package-lock) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sender of the innerTransaction is Bob as he will later sign the transaction. The sender is overwritten anyways so it doesn't matter much in terms of results, but it's confusing for people wanting to learn about the relayedTransactionV2Builder :)