Make axios and bls optional #505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popenta
previously approved these changes
Oct 14, 2024
README.md
Outdated
|
|
||
| ### axios | ||
|
|
||
| This package can make HTTP requests using `axios`, but it is not bundled by default. If you plan to use the API network provider or Proxy network provider, make sure to install `axios`: |
Contributor
There was a problem hiding this comment.
but it is not -> which is not (optional) (here and below).
| } | ||
|
|
||
| private async doGet(resourceUrl: string): Promise<any> { | ||
| let axios = await getAxios(); |
Contributor
There was a problem hiding this comment.
Can be const (here and below).
src/utils.ts
Outdated
| export async function getAxios() { | ||
| let axios; | ||
| try { | ||
| axios = require("axios"); |
Contributor
There was a problem hiding this comment.
Can return directly, without declaring let axios above.
|
|
||
| export class BLS { | ||
| private static isInitialized: boolean = false; | ||
| public static bls: any; |
Contributor
There was a problem hiding this comment.
A bit tricky. C#'s internal would have been nice here :)
Though, since we plan to drop Herumi's library, it's fine 👍
Alternative: private field and a public function getUnderlyingComponent() (or something similar).
Contributor
Author
There was a problem hiding this comment.
I will let it like this since we plan to drop it
andreibancioiu
approved these changes
Oct 15, 2024
popenta
approved these changes
Oct 15, 2024
danielailie
deleted the
TOOL-264-bring-sdk-wallet-into-sdk-core-optional-dependencies
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.