Update address to follow specs #552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
TOOL-405-update-to-use-new-methods-on-token-transfer
to
feat/next
December 17, 2024 14:11
andreibancioiu
previously approved these changes
Dec 17, 2024
popenta
reviewed
Dec 17, 2024
src/abi/interaction.spec.ts
Outdated
| const hexLKMEX = "4c4b4d45582d616162393130"; | ||
| const hexNFT = "4d4f532d623962346232"; | ||
| const hexContractAddress = new Address(contract.getAddress().toBech32()).hex(); | ||
| const hexContractAddress = new Address(contract.getAddress().toBech32()).toHex(); |
Contributor
There was a problem hiding this comment.
I think this could have been:
const hexContractAddress = contract.getAddress().toHex();
src/abi/smartContract.ts
Outdated
| */ | ||
| static computeAddress(owner: Address, nonce: bigint): Address { | ||
| const deployer = Address.fromBech32(owner.toBech32()); | ||
| const deployer = Address.newFromBech32(owner.toBech32()); |
Contributor
There was a problem hiding this comment.
owner was already of type Address.
| const dataParts = [ | ||
| "SetGuardian", | ||
| Address.fromBech32(options.guardianAddress.bech32()).toHex(), | ||
| Address.newFromBech32(options.guardianAddress.toBech32()).toHex(), |
Contributor
There was a problem hiding this comment.
could have been:
options.guardianAddress.toHex()| newOwner: Address; | ||
| }): Transaction { | ||
| const dataParts = ["ChangeOwnerAddress", Address.fromBech32(options.newOwner.toBech32()).toHex()]; | ||
| const dataParts = ["ChangeOwnerAddress", Address.newFromBech32(options.newOwner.toBech32()).toHex()]; |
Contributor
There was a problem hiding this comment.
could have been:
options.newOwner.toHex()
src/utils.codec.ts
Outdated
Comment on lines
56
to
58
| export function addressToHex(address: Address): string { | ||
| const buffer = Address.fromBech32(address.toString()).pubkey(); | ||
| const buffer = Address.newFromBech32(address.toString()).getPublicKey(); | ||
| return buffer.toString("hex"); |
Contributor
There was a problem hiding this comment.
I think this is not needed since an Address can be eaasily converted to hex string. If still needed perhaps simply return address.toHex()?
andreibancioiu
approved these changes
Dec 18, 2024
popenta
approved these changes
Dec 18, 2024
| const deployer = Address.newFromBech32(owner.toBech32()); | ||
| const addressComputer = new AddressComputer(); | ||
| return addressComputer.computeContractAddress(deployer, BigInt(nonce.valueOf())); | ||
| return addressComputer.computeContractAddress(owner, BigInt(nonce.valueOf())); |
Contributor
There was a problem hiding this comment.
The nonce is already of type bigint.
Contributor
There was a problem hiding this comment.
Can be chaged in a future PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.