Fix contract results parsing #602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| for (const result of transactionOnNetwork.smartContractResults) { | ||
| const matchesCriteriaOnData = result.data.toString().startsWith(ARGUMENTS_SEPARATOR); | ||
| const matchesCriteriaOnData = Buffer.from(result.data).toString("utf-8").startsWith(ARGUMENTS_SEPARATOR); |
There was a problem hiding this comment.
Good point, applying toString() on data: Uint8Array was tricky.
| nonce: 7n, | ||
| function: "getUltimateAnswer", | ||
| smartContractResults: [new SmartContractResult({ data: Buffer.from("@6f6b@2a") })], | ||
| smartContractResults: [new SmartContractResult({ data: Buffer.from("QDZmNmJAMmE=", "base64") })], |
There was a problem hiding this comment.
I think the inconsistencies between API and Proxy are not yet reconciled at the SDK level, thus a further fix is needed.
- https://github.com/multiversx/mx-sdk-js-core/blob/main/src/core/transactionOnNetwork.ts#L71
- https://github.com/multiversx/mx-sdk-js-core/blob/main/src/core/transactionOnNetwork.ts#L141
On proxy, it's an UTF-8 string (it's sub-components being hex-encoded):
On API, it's a base64-encoded string:
Good catch 🎉
We'll discuss this a bit internally, then come back.
There was a problem hiding this comment.
Actually, I think we can approve this PR, since there's no change in the implementation with respect to this issue - there's only the fix in smartContractTransactionsOutcomeParser.ts. And we can handle the Proxy - API inconsistency in a separate PR.
andreibancioiu
approved these changes
May 5, 2025
danielailie
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test incorrectly assumes that contract results are returned in hex – it's base64 instead.
Quick debugging insight showcasing the invalid base64 <> hex comparison: