Allow null payload for deletion feature #409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Should we only allow None values if a key is provided? Also I think it is worth adding a comment w/ a link to relevant apache kafka protocol docs. Shouldn't we add a test or two as well? |
Contributor
Author
|
Yeah, good catch: I think that message with no key and no payload doesn't make sense at all. I'll add a comment with a link and some tests. |
Contributor
Author
|
@dpkp Check it please, do we need to add something else here? |
dpkp
added a commit
that referenced
this pull request
Dec 2, 2015
Allow null payload for deletion feature
Contributor
Author
|
Thanks! 👯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #408.