Fix translation of Java murmur2 code, fix byte encoding for Python 3. #439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid further type changes when Murmur2Partitioner is passed a byte array. Change leftover-bytes logic to match the Java switch statement, and add tests to verify that partition selection matches Java implementation.
dpkp
added a commit
that referenced
this pull request
Dec 2, 2015
Fix translation of Java murmur2 code, fix byte encoding for Python 3.
This was referenced Dec 2, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Murmur2Partitioner currently doesn't run on Python 3, or when it
is passed a bytearray, and it differs from the Kafka Java implementation in its
handling of leftover bytes (the Java switch statement falls through between
cases).
This PR:
Avoid further type changes when Murmur2Partitioner is passed a byte
array. Change leftover-bytes logic to match the Java switch statement,
and add tests to verify that partition selection matches Java implementation.