Skip to content

Conversation

@muneebhashone
Copy link
Owner

…clusions

@gemini-code-assist
Copy link

Summary of Changes

Hello @muneebhashone, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refines the project's scaffolding experience by migrating the CLI's interactive prompting mechanism to a more modern library and introducing powerful new command-line options for automation and flexibility. Concurrently, it streamlines the codebase by removing an entire module, indicating a focus on core features or a restructuring of project components. These changes aim to improve developer workflow and maintainability.

Highlights

  • CLI Prompting Library Migration: The project's command-line interface (CLI) has been refactored to use @clack/prompts instead of inquirer, providing a more modern and streamlined interactive experience for project scaffolding.
  • Enhanced CLI Options and Flow: New CLI options like --yes (skip prompts) and --force (overwrite existing directories) have been introduced, alongside a more robust logic for handling interactive and non-interactive project creation flows.
  • Removal of Blog Module: The entire blog module, including its controllers, DTOs, models, routers, schemas, services, factories, and seeders, has been removed from the project.
  • .gitignore Update: The .gitignore file has been updated to include .codacy directories, ensuring that Codacy-related files are properly excluded from version control.
  • README Documentation Updates: The README.md for create-tbk-app has been updated to reflect the new CLI options and provide clearer examples for guided prompts, non-interactive mode, and custom configurations.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/publish-package.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a significant and well-executed refactoring of the create-tbk-app CLI. The migration from inquirer to @clack/prompts greatly enhances the user experience, introducing clearer prompts, spinners, and a confirmation summary. The logic for handling CLI flags is now more robust, with improved validation and normalization. I particularly appreciate the new interactive flow for managing existing project directories. The documentation updates are thorough and accurately reflect the new functionalities. The removal of the example blog module is also a sensible cleanup. Overall, this is a high-quality improvement. I've identified one minor bug due to a typo and a small opportunity to improve type safety.

Comment on lines +286 to +296
const selectPrompt = select as unknown as (opts: {
message: string;
options: Choice<T>[];
initialValue?: T;
}) => Promise<T | symbol>;

const result = await selectPrompt({
message,
options,
initialValue,
});

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The type assertion select as unknown as ... seems unnecessary and bypasses TypeScript's type safety. The select function from @clack/prompts is generic, and its type should be correctly inferred from the provided options. Removing the assertion makes the code cleaner and safer.

Suggested change
const selectPrompt = select as unknown as (opts: {
message: string;
options: Choice<T>[];
initialValue?: T;
}) => Promise<T | symbol>;
const result = await selectPrompt({
message,
options,
initialValue,
});
const result = await select({
message,
options,
initialValue,
});

@muneebhashone muneebhashone merged commit acd1623 into main Nov 1, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants