-
Notifications
You must be signed in to change notification settings - Fork 56
chore: update .gitignore to include .codacy and ensure proper file ex… #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @muneebhashone, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refines the project's scaffolding experience by migrating the CLI's interactive prompting mechanism to a more modern library and introducing powerful new command-line options for automation and flexibility. Concurrently, it streamlines the codebase by removing an entire module, indicating a focus on core features or a restructuring of project components. These changes aim to improve developer workflow and maintainability. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is a significant and well-executed refactoring of the create-tbk-app CLI. The migration from inquirer to @clack/prompts greatly enhances the user experience, introducing clearer prompts, spinners, and a confirmation summary. The logic for handling CLI flags is now more robust, with improved validation and normalization. I particularly appreciate the new interactive flow for managing existing project directories. The documentation updates are thorough and accurately reflect the new functionalities. The removal of the example blog module is also a sensible cleanup. Overall, this is a high-quality improvement. I've identified one minor bug due to a typo and a small opportunity to improve type safety.
| const selectPrompt = select as unknown as (opts: { | ||
| message: string; | ||
| options: Choice<T>[]; | ||
| initialValue?: T; | ||
| }) => Promise<T | symbol>; | ||
|
|
||
| const result = await selectPrompt({ | ||
| message, | ||
| options, | ||
| initialValue, | ||
| }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The type assertion select as unknown as ... seems unnecessary and bypasses TypeScript's type safety. The select function from @clack/prompts is generic, and its type should be correctly inferred from the provided options. Removing the assertion makes the code cleaner and safer.
| const selectPrompt = select as unknown as (opts: { | |
| message: string; | |
| options: Choice<T>[]; | |
| initialValue?: T; | |
| }) => Promise<T | symbol>; | |
| const result = await selectPrompt({ | |
| message, | |
| options, | |
| initialValue, | |
| }); | |
| const result = await select({ | |
| message, | |
| options, | |
| initialValue, | |
| }); |
…clusions