-
-
Notifications
You must be signed in to change notification settings - Fork 5
❇️ Add SMPP Solver and further Improvements for the Precompilation an #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## qce_implementation #34 +/- ##
====================================================
+ Coverage 96.7% 97.8% +1.1%
====================================================
Files 4 5 +1
Lines 61 94 +33
====================================================
+ Hits 59 92 +33
Misses 2 2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't completely scrutinised everything, but roughly went through all the changes.
Just a very small comment. Otherwise this LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These result files shouldn't go into the top level directory, right? I'd suggest moving them to a dedicated folder to not pollute the top-level one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I adjust it and merge the PR afterwards.
docs: 📝 Add citations to arxiv paper
docs: 📝 Add citations to arxiv paper
docs: 📝 Add citations to arxiv paper
This PR...
❇️ adds the Satellite Mission Planning Problem (SMPP) solver
🎨 improves the Precompilation Scheme for various aspects (with a focus on the evaluations)