Skip to content

Conversation

@nquetschlich
Copy link
Collaborator

@nquetschlich nquetschlich commented Apr 28, 2023

This PR...
❇️ adds the Satellite Mission Planning Problem (SMPP) solver
🎨 improves the Precompilation Scheme for various aspects (with a focus on the evaluations)

@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #34 (68de7c9) into qce_implementation (f21ae3a) will increase coverage by 1.1%.
The diff coverage is 100.0%.

@@                 Coverage Diff                  @@
##           qce_implementation     #34     +/-   ##
====================================================
+ Coverage                96.7%   97.8%   +1.1%     
====================================================
  Files                       4       5      +1     
  Lines                      61      94     +33     
====================================================
+ Hits                       59      92     +33     
  Misses                      2       2             
Impacted Files Coverage Δ
tests/test_satellitesolver.py 100.0% <100.0%> (ø)

@nquetschlich nquetschlich requested a review from burgholzer April 28, 2023 08:51
@nquetschlich nquetschlich added enhancement New feature or request feature New feature or request minor Part of a minor release labels Apr 28, 2023
@nquetschlich nquetschlich self-assigned this Apr 28, 2023
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't completely scrutinised everything, but roughly went through all the changes.
Just a very small comment. Otherwise this LGTM.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These result files shouldn't go into the top level directory, right? I'd suggest moving them to a dedicated folder to not pollute the top-level one.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I adjust it and merge the PR afterwards.

@nquetschlich nquetschlich merged commit 2db153c into qce_implementation May 5, 2023
@nquetschlich nquetschlich deleted the qce_improvements branch May 5, 2023 07:10
tobi-forster pushed a commit that referenced this pull request May 15, 2025
tobi-forster pushed a commit that referenced this pull request May 15, 2025
docs: 📝 Add citations to arxiv paper
DRovara added a commit that referenced this pull request Oct 16, 2025
docs: 📝 Add citations to arxiv paper
DRovara added a commit that referenced this pull request Oct 16, 2025
docs: 📝 Add citations to arxiv paper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request feature New feature or request minor Part of a minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants