Improve level1.js and fix bug in level3.js #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danny-wu
commented
Nov 22, 2017
|
|
||
| /* | ||
| Multi-line comments look like this. | ||
| When you are writing actual code, put it outside these comment blocks, |
Contributor
Author
There was a problem hiding this comment.
People often get confused and put code inside the comments. Hopefully this makes it clearer
danny-wu
commented
Nov 22, 2017
| There are a few ways you can do it and we will look into a few of them: | ||
| * alert('Hello girls!'); | ||
| alert('Hello girls!'); |
Contributor
Author
There was a problem hiding this comment.
People usually write things with the *, like *alert('Hello girls!');.
* is not used anywhere else in these files; so hopefully this makes it clearer.
danny-wu
commented
Nov 22, 2017
| This will pop-up an alert box with the number 4. | ||
| (You can see a full list of ) | ||
| TIP: Note how we didn't put 1 and 3 in quotes, because they are numbers. |
Contributor
Author
There was a problem hiding this comment.
clarify, so people don't do '1' + '3' like people often do
danny-wu
commented
Nov 22, 2017
| Example: | ||
| var pageNode = document.querySelector('body')[0]; |
Contributor
Author
There was a problem hiding this comment.
Accessing [0] on a single Element is going to give you an error. You only need to do [0] if you're using document.querySelectorAll
Contributor
Author
|
cc @ButenkoT |
ButenkoT
approved these changes
Jan 19, 2018
js/level1.js
Outdated
| A function is a reusable piece of code, an action that you want to do. | ||
| It takes some input (arguments), does some manipulation on it and returns | ||
| the output. Use the keyword 'return' to define the return value. | ||
| A function is lkike a blueprint, an action that you want to do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some suggested changes from what I've observed mentoring this workshop, and a bugfix. See inline comments :)