Fix some more warnings manually

Author: Jojo-Schmitz

audio/exports/exportmp3.cpp

@@ -138,7 +138,7 @@ bool MP3Exporter::loadLibrary(AskUser askuser)
                    "the freely available LAME library. You must obtain %1 "
                    "separately (for details check the handbook), and then locate the file for MuseScore.\n"
                    "You only need to do this once.\n\n"
-                   "Would you like to locate %2 now?").arg(getLibraryName()).arg(getLibraryName()),
+                   "Would you like to locate %2 now?").arg(getLibraryName(), getLibraryName()),
                    QMessageBox::Yes|QMessageBox::No, QMessageBox::NoButton);
             if (ret == QMessageBox::Yes && findLibrary()) {
                   mLibraryLoaded = initLibrary(mLibPath);

audio/midi/event.cpp

@@ -311,7 +311,7 @@ void Event::write(XmlWriter& xml) const
                               QString sex(_edata[1] ? "Minor" : "Major");
                               QString keyName(keyTable[key]);
                               xml.tag(QString("Key tick=\"%1\" key=\"%2\" sex=\"%3\"").arg(ontime()).arg(_edata[0]).arg(_edata[1]),
-                                 QString("%1 %2").arg(keyName).arg(sex));
+                                 QString("%1 %2").arg(keyName, sex));
                               }
                               break;
 

audio/midi/fluid/fluid.cpp

@@ -973,7 +973,7 @@ QFileInfoList Fluid::sfFiles()
       QFileInfoList l;
 
       QStringList pl = preferences.getString(PREF_APP_PATHS_MYSOUNDFONTS).split(";");
-      pl.prepend(QFileInfo(QString("%1%2").arg(mscoreGlobalShare).arg("sound")).absoluteFilePath());
+      pl.prepend(QFileInfo(QString("%1%2").arg(mscoreGlobalShare, "sound")).absoluteFilePath());
 
       // append extensions directory
       QStringList extensionsDir = Ms::Extension::getDirectoriesByType(Ms::Extension::soundfontsDir);

audio/midi/zerberus/instrument.cpp

@@ -43,8 +43,6 @@ Sample::~Sample()
 Sample* ZInstrument::readSample(const QString& s, MQZipReader* uz)
       {
       if (uz) {
-            QVector<MQZipReader::FileInfo> fi = uz->fileInfoList();
-
             buf = uz->fileData(s);
             if (buf.isEmpty()) {
                   printf("Sample::read: cannot read sample data <%s>\n", qPrintable(s));

awl/aslider.cpp

@@ -27,7 +27,7 @@ namespace Awl {
 //---------------------------------------------------------
 
 AbstractSlider::AbstractSlider(QWidget* parent)
-   : QWidget(parent), _scaleColor(Qt::darkGray), _scaleValueColor(QColor("#2456aa"))
+   : QWidget(parent), _scaleColor(Qt::darkGray), _scaleValueColor(QColor(0x2456aa))
       {
       __id         = 0;
       _value      = 0.5;

awl/styledslider.cpp

@@ -85,7 +85,7 @@ void StyledSlider::mousePressEvent(QMouseEvent* e)
       draggingMouse = true;
       mouseDownPos = e->pos();
       mouseDownVal = _value;
-      emit(sliderPressed());
+      emit sliderPressed();
       }
 
 //---------------------------------------------------------
@@ -219,7 +219,7 @@ void StyledSlider::setValue(double v)
 
       _value = v;
       update();
-      emit(valueChanged(v));
+      emit valueChanged(v);
       }
 
 //---------------------------------------------------------
@@ -232,7 +232,7 @@ void StyledSlider::setMinValue(double v)
             return;
       _minValue = v;
       update();
-      emit(minValueChanged(v));
+      emit minValueChanged(v);
       }
 
 //---------------------------------------------------------
@@ -245,7 +245,7 @@ void StyledSlider::setMaxValue(double v)
             return;
       _maxValue = v;
       update();
-      emit(maxValueChanged(v));
+      emit maxValueChanged(v);
       }
 
 //---------------------------------------------------------

importexport/bb/bb.cpp

@@ -382,7 +382,7 @@ bool BBFile::read(const QString& name)
 Score::FileError importBB(MasterScore* score, const QString& name)
       {
       BBFile bb;
-      if(!QFileInfo(name).exists())
+      if(!QFileInfo::exists(name))
             return Score::FileError::FILE_NOT_FOUND;
       if (!bb.read(name)) {
             qDebug("Cannot open file <%s>", qPrintable(name));

importexport/guitarpro/importgtp-gp6.cpp

@@ -403,7 +403,7 @@ void GuitarPro6::readChord(QDomNode* diagram, int track)
 
       // get the identifier to set as the domain in the map
       int id    = diagram->attributes().namedItem("id").toAttr().value().toInt();
-      auto name = diagram->attributes().namedItem("name").toAttr().value();
+//TODO-ws      auto name = diagram->attributes().namedItem("name").toAttr().value();
 
 //TODO-ws      fretDiagram->setChordName(name);
       QDomNode diagramNode = diagram->firstChild();
@@ -2363,7 +2363,6 @@ void GuitarPro6::readMasterBars(GPPartInfo* partInfo)
                                     volta->setTick(measure->tick());
                                     volta->setTick2(measure->tick() + measure->ticks());
 
-                                    QList<int> endings;
                                     const char* c = endNumbers.toUtf8().constData();
                                     while (c && *c)
                                           {

importexport/musedata/musedata.cpp

@@ -740,7 +740,7 @@ void MuseData::convert()
 
 Score::FileError importMuseData(MasterScore* score, const QString& name)
       {
-      if(!QFileInfo(name).exists())
+      if(!QFileInfo::exists(name))
             return Score::FileError::FILE_NOT_FOUND;
       MuseData md(score);
       if (!md.read(name))

importexport/musicxml/exportxml.cpp

@@ -1587,7 +1587,7 @@ static void ending(XmlWriter& xml, Volta* v, bool left)
                         return;
                   }
             }
-      QString voltaXml = QString("ending number=\"%1\" type=\"%2\"").arg(number).arg(type);
+      QString voltaXml = QString("ending number=\"%1\" type=\"%2\"").arg(number, type);
       voltaXml += positioningAttributes(v, left);
       xml.tagE(voltaXml);
       }
@@ -3299,8 +3299,6 @@ void ExportMusicXml::chord(Chord* chord, int staff, const std::vector<Lyrics*>*
 #endif
 
       for (Note* note : nl) {
-            QString val;
-
             _attr.doAttr(_xml, false);
             QString noteTag = QString("note");
 
@@ -3775,7 +3773,7 @@ static bool findMetronome(const QList<TextFragment>& list,
             if (words.length() > pos2 + len2) {
                   QString s1 = words.mid(0, pos1);     // string to the left of metronome
                   QString s2 = words.mid(pos1, len1);  // first note
-                  QString s3 = words.mid(pos2, len2);  // equals sign
+                  //QString s3 = words.mid(pos2, len2);  // equals sign
                   QString s4 = words.mid(pos2 + len2); // string to the right of equals sign
                   /*
                   qDebug("found note and equals: '%s'%s'%s'%s'",
@@ -4279,7 +4277,7 @@ void ExportMusicXml::ottava(Ottava const* const ot, int staff, const Fraction& t
                         qDebug("ottava subtype %d not understood", int(st));
                   }
             if (sz && tp)
-                  octaveShiftXml = QString("octave-shift type=\"%1\" size=\"%2\" number=\"%3\"").arg(tp).arg(sz).arg(n + 1);
+                  octaveShiftXml = QString("octave-shift type=\"%1\" size=\"%2\" number=\"%3\"").arg(tp, sz).arg(n + 1);
             }
       else {
             if (st == OttavaType::OTTAVA_8VA || st == OttavaType::OTTAVA_8VB)