Skip to content

Conversation

@musicEnfanthen
Copy link
Member

As laid out in #617, it's better to use a key string first, language string second approach for the tutorialStrings mapping. This will make it easier to add new languages or new strings in the future.

Fixes #617

Copy link
Member

@rettinghaus rettinghaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rettinghaus rettinghaus merged commit 9114be8 into music-encoding:main May 15, 2024
@musicEnfanthen
Copy link
Member Author

Thank you!

@musicEnfanthen musicEnfanthen deleted the develop-tutorials branch May 15, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Technical issues

Development

Successfully merging this pull request may close these issues.

Tutorials: refactor tutorialStrings mapping

2 participants