ci: update jekyll build workflow #738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rettinghaus
reviewed
Feb 2, 2025
Member
rettinghaus
left a comment
rettinghaus
left a comment
There was a problem hiding this comment.
Looks good to me. Could you try it on your fork?
Member
Author
|
No, I couldn't. Not sure where it gets deployed to because of the CNAME. |
lpugin
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Jekyll build workflow, according to the following sources:
This also requires the settings to be updated to "Change Source under Build and deployment from
Deploy from a branchtoGitHub Actions."However, there is neither a guarantee nor a way to test whether this modified workflow works. So please proceed with caution.