Skip to content

fix: use a more stable key #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 26, 2022
+3 −4
Merged

fix: use a more stable key #651

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fc67f9
fix: use a more stable key
kevmo314 Aug 26, 2022
7501c74
Update scroll_view.dart
kevmo314 Aug 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions lib/components/pinnable/scroll_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,11 @@ class PinnableMessageScrollView extends ScrollView {
(index) => isPinnedBuilder(index) != PinState.notPinnable,
orElse: () => count);
final intermediateCount = nextPinnableIndex - start;
// key from the distance to the end of the list, which is the most stable identifier.
if (intermediateCount > 0) {
final offset = start;
final sliver = SliverList(
// key by first and last message id.
key: ValueKey("$start-$nextPinnableIndex"),
key: ValueKey(count - nextPinnableIndex + 1),
delegate: SliverChildBuilderDelegate(
(context, index) => itemBuilder(index + offset),
findChildIndexCallback: (key) {
Expand All @@ -70,8 +70,7 @@ class PinnableMessageScrollView extends ScrollView {
}
final pinned = isPinnedBuilder(nextPinnableIndex);
final sliver = PinnableMessageSliver(
// key by index.
key: ValueKey(start),
key: ValueKey(count - nextPinnableIndex),
vsync: vsync,
pinned: pinned == PinState.pinned,
child: AnimatedContainer(
Expand Down