fix: do not reuse oauth members#243
Merged
codingLogan merged 1 commit intomasterfrom Oct 23, 2025
Merged
Conversation
codingLogan
requested review from
Jameson13B,
ash-wright123,
emilysallstrom,
mwclemy and
wesrisenmay-mx
as code owners
emilysallstrom
approved these changes
Oct 23, 2025
Collaborator
|
I really do not agree with this change. When I was told about the original issue, my thought was this is a backend fix, not something in the widget. Removing this does not seem like a fix, let alone the fix we are wanting. |
Collaborator
|
Any fix that introduces more issues doesn't seem to be the correct fix. Also, if we have a member already, why are we creating new members instead of keeping the existing one. This all just seems off but I have also been out yesterday. |
|
🎉 This PR is included in version 2.13.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a previously reported bug that was re-introduced
(Fixes the bug) The original change in Jan: c65fcd1
(Re-introduced the bug, but fixed some analytics) The revert of that change in Sept: https://github.com/mxenabled/connect-widget/pull/218/files
(Re-fixes the bug, and will likely break some analytics again) This PR undoes the revert, to get us close to back to the January fix
Moving forward we need to figure out what is happening with the analytics, and NOT re-introduce the bug.