Skip to content

Conversation

@yiyuan-he
Copy link

@yiyuan-he yiyuan-he commented Oct 15, 2024

Description of Changes:

Strange dependency conflicts between old and new tests are causing PR build failures. Temporarily disabling them.

Due to time constraints, we will deep dive into reasons why these dependency conflicts are happening and figure out a long-term fix after new SDK version of Java is released.

Test Plan:
Ran successfully:

./gradlew clean build

and verified the end-to-end span attribute generation is still working.

Created a patch with command:

git diff release/v1.32.x fix-build >> opentelemetry-java-instrumentation.patch

and ran patching script + contract tests:

aws ecr-public get-login-password --region us-east-1 | docker login --username AWS --password-stdin public.ecr.aws
./scripts/local_patch.sh
./gradlew :appsignals-tests:contract-tests:contractTests

@yiyuan-he yiyuan-he closed this Oct 17, 2024
@yiyuan-he yiyuan-he reopened this Oct 17, 2024
@mxiamxia mxiamxia merged commit 749d025 into mxiamxia:v1_32_1_dev Oct 25, 2024
38 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants