Support overloaded methods mapped to individual statements

[wangliwang777]

MyBatis version

3.4.6

Database vendor and version

Test case or example project

Steps to reproduce

Expected result

Actual result

[kezhenxu94]

Reasonable, I'll try to fix this and open a PR later

[kezhenxu94]

@wangwang911 After checking for a while, I think this is impossible since MyBatis use full qualified method name as identifier in the whole project, change the identifier will broke many things, see the failed unit tests. So you have to change your method name for now

[harawata]

So, this is another request for supporting method overloading, right?
There was a similar request #1312 and I have a possible solution [1], but I'm not sure if it's really necessary.
Let me try to explain...

Most users who requested method overloading seemed to want to map multiple overloaded methods to a single XML statement (e.g. #705 ).
For example, mapping the following two methods...

User findUser(Integer id);
User findUser(Integer id, String name);

...to this XML statement.

<select id="findUser" resultType="User">
  select from users where id = #{id}
  <if test="name != null">
    and name = #{name}
  </if>
</select>

It is already possible with Java 8's default methods.

default User findUser(Integer id) {
  return findUser(id, null);
}
User findUser(Integer id, String name);

In your case, however, each method is mapped to a different statement.
And, to me, it seems to be better to name these methods differently (e.g. selectAreaByCreationDate and selectAreaByRange).
What do you think?

[1] Add a new annotation @StatementId to allow users to assign statement ID explicitly.

[wangliwang777]

For me, I like the way overloading differentiates different methods. So I think it's a good idea to add @StatementId.

[harawata]

Okay, I'll look into the idea.
Thank you for the feedback!

[harawata]

Hi @wangwang911 @kezhenxu94 ,
I seem to have forgotten to add a comment here, but #1519 is the PR that adds @StatementId I mentioned.
Let us know what you think!

[kezhenxu94]

Hi @wangwang911 @kezhenxu94 ,
I seem to have forgotten to add a comment here, but #1519 is the PR that adds @StatementId I mentioned.
Let us know what you think!

Hi @harawata , the PR #1519 looks good to me, let's see what others' opinions

[wangliwang777]

Hi @wangwang911 @kezhenxu94 ,
I seem to have forgotten to add a comment here, but #1519 is the PR that adds @StatementId I mentioned.
Let us know what you think!

Hi @harawata , I also think PR #1519 is a good solution.