-
Couldn't load subscription status.
- Fork 13k
Code polish #1634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code polish #1634
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @a827871781 !
Requesting a few minor changes (no rush).
src/main/java/org/apache/ibatis/builder/annotation/MapperAnnotationBuilder.java
Show resolved
Hide resolved
| import java.util.Properties; | ||
| import java.util.Set; | ||
| import java.util.*; | ||
| import java.util.stream.Collectors; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No star imports, please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how to use github, I made some changes to your reply. Thank you
src/main/java/org/apache/ibatis/builder/annotation/MapperAnnotationBuilder.java
Show resolved
Hide resolved
| import java.util.Properties; | ||
| import java.util.Set; | ||
| import java.util.*; | ||
| import java.util.stream.Collectors; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
No description provided.