Skip to content

Conversation

@a827871781
Copy link

No description provided.

@harawata harawata added the polishing Improve a implementation code or doc without change in current behavior/content label Sep 1, 2019
@harawata harawata changed the title Submit PR for the first time, about Java8 features and API usage Code polish Sep 1, 2019
Copy link
Member

@harawata harawata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @a827871781 !

Requesting a few minor changes (no rush).

import java.util.Properties;
import java.util.Set;
import java.util.*;
import java.util.stream.Collectors;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No star imports, please.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Author

@a827871781 a827871781 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how to use github, I made some changes to your reply. Thank you

import java.util.Properties;
import java.util.Set;
import java.util.*;
import java.util.stream.Collectors;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

polishing Improve a implementation code or doc without change in current behavior/content

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants