Use private member in temperature example

[Ducatel]

Hi everybody,

In Dallas temperature example there is a bad call to private member

error: 'int16_t DallasTemperature::millisToWaitForConversion(uint8_t)' is private

According to the Dallas library.

So this error should be fixed in example or in the library ?

Thanks ;)

[henrikekblad]

Nope, it is in the public section:
https://github.com/mysensors/MySensorsArduinoExamples/blob/master/libraries/DallasTemperature/DallasTemperature.h#L121

[Ducatel]

oh, you don't use the official version of the library.
Why ? What is the reason for that ?
So this example cannot be use in a real code ?

Quick view of my arduino/Mysensor builder script

arduino --install-library "MySensors"
arduino --install-library "OneWire"
arduino --install-library "DallasTemperature" # This line not install the "custom" version 
.......

arduino --verify --board arduino:avr:uno  src/temp.ino # fail because of the private call

This is not the good way to build a MySensor project ?

[henrikekblad]

Well, it seems to have been needed by @roboprint back in 2015. Guess he found it useful in the example.

mysensors/MySensors@e47e596

mysensors/MySensors@dffec69

[Ducatel]

Ok so it's usefull for us.
So I will make a PR to the official Dallas lib ;)

[henrikekblad]

👍

When it is in, you can remove the Dallas library from this repo.

[roboprint]

This is used for non-blocking temperature reading. You cannot receive messages from MySensors, send messages or do other tasks during 750 millisecond thread-blocking temperature conversion. Blocking calls isn't very good solution for MySensors nodes providing other interactive functions to users (light switch as example).

Right way is do PR into Dallas lib, but as far as I remember in those days Dallas library was bundled with MySensors.