Skip to content

Added TCP_NODELAY and TCP_KEEPALIVE on default connection #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

webloft
Copy link

@webloft webloft commented Sep 3, 2021

No description provided.

@schveiguy
Copy link
Collaborator

Thanks, but my thought was actually to just change the default in the socket creation routine, not make a public option to configure it. You can already configure the socket via the callback, I just want the default to be what is expected.

Can you make a PR that just does this?

@schveiguy
Copy link
Collaborator

I have a few minutes today, I'm just going to implement what I think is the right thing.

@webloft
Copy link
Author

webloft commented Sep 4, 2021

You mean directly in MySQLSocketPhobos class? I just thought that wouldn't be flexible enough if someone need to create a socket if one just want to disable a feature, for whatever reason.

@schveiguy
Copy link
Collaborator

Just hang on about 10 minutes, I'm almost done.

@schveiguy
Copy link
Collaborator

Take a look, this is what I want to do (still working on changelog, then will set up a PR): https://github.com/schveiguy/mysql-native/tree/tcpnodelay

@webloft
Copy link
Author

webloft commented Sep 4, 2021

OK, then I will close this

@webloft webloft closed this Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants