Standard mysql uses the socket options for TCP_NODELAY and KEEPALIVE. #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @webloft this is what I'm thinking should be done. |
should do the same. One can always override the defaults by setting a callback socket creation routine.
schveiguy
force-pushed
the
tcpnodelay
branch
from
313675b to
d0b8776
Compare
|
All green. Good to have at least another set of eyes on it. Any comments? If I don't hear by tomorrow, I'll merge and then do a new release. Ping @kubo39 too. BTW, thanks for poking me enough to get me to realize the discrepancy between the official library and this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rehash of #221 and #248 . This should fix #247