Bug#36292125 use-after-free in async-recv

ASAN reported a use-after-free when a Channel is std::move()d in
async_recv().

1. the move() .cancel()s all async-operations
2. the async operation MUST not touch anything if it is canceled.

async_recv() calls view_sync_raw() on a destructed part of the
moved-channel.

Change
======

- only sync the view on success of the async operation.

Change-Id: I82d9ea666c4db5a8962d4f63ac1cbc3884974d4e

Author: weigon

router/src/routing/src/basic_protocol_splicer.h

@@ -364,7 +364,9 @@ class TlsSwitchableConnection {
     conn_->async_recv(channel_->recv_buffer(),
                       [this, func = std::forward<Func>(func)](
                           std::error_code ec, size_t transferred) {
-                        channel_->view_sync_raw();
+                        if (ec == std::error_code()) {
+                          channel_->view_sync_raw();
+                        }
 
                         func(ec, transferred);
                       });