Bug #30163412: RUN CLANG-TIDY MODERNIZE-USE-BOOL-LITERALS

This is the first cross-cutting, large-scale clang-tidy fix. It runs the
“modernize-use-bool-literal” fixit over all source code compiled in a fairly
full-featured MySQL build, changing integral literals to bool literals when
used in a boolean context. A typical example would be:

-      print_comment(sql_file, 0, "-- Dump completed on %s\n", time_str);
+      print_comment(sql_file, false, "-- Dump completed on %s\n", time_str);

as the second argument to print_comment() is “bool is_error”.

Converting 0 and 1 literals to false and true makes code easier to read by
increasing self-documentation, makes type and argument order mistakes more
difficult, enable compiler warnings when nonsensical operations are attempted
(such as multiplying bools), and reduces noise from IDEs and other tools that
check clang-tidy warnings.

Change-Id: I8070dc592cd0341993d2b4261a3949b71ac5e916

Author: Steinar H. Gunderson

client/base/abstract_program.cc

@@ -1,5 +1,5 @@
 /*
-   Copyright (c) 2014, 2018, Oracle and/or its affiliates. All rights reserved.
+   Copyright (c) 2014, 2019, Oracle and/or its affiliates. All rights reserved.
 
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License, version 2.0,
@@ -44,7 +44,7 @@ bool Abstract_program::callback_option_parsed(int, const struct my_option *opt,
   if (option != NULL) {
     option->call_callbacks(argument);
   }
-  return 0;
+  return false;
 }
 
 const string Abstract_program::get_name() { return this->m_name; }

client/base/debug_options.cc

@@ -1,5 +1,5 @@
 /*
-   Copyright (c) 2014, 2017, Oracle and/or its affiliates. All rights reserved.
+   Copyright (c) 2014, 2019, Oracle and/or its affiliates. All rights reserved.
 
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License, version 2.0,
@@ -82,7 +82,7 @@ void Debug_options::debug_option_callback(
   if (this->m_dbug_option.has_value()) {
     DBUG_PUSH(this->m_dbug_option.value().c_str());
   }
-  this->m_debug_check_flag = 1;
+  this->m_debug_check_flag = true;
 }
 
 void Debug_options::options_parsed() {

client/base/ssl_options.cc

@@ -94,7 +94,7 @@ bool Mysql_connection_options::Ssl_options::apply_for_connection(
     MYSQL *connection) {
   if (SSL_SET_OPTIONS(connection)) {
     std::cerr << SSL_SET_OPTIONS_ERROR;
-    return 1;
+    return true;
   }
-  return 0;
+  return false;
 }

client/check/mysqlcheck.cc

@@ -53,16 +53,17 @@ using std::vector;
 #define EX_MYSQLERR 2
 
 static MYSQL mysql_connection, *sock = 0;
-static bool opt_alldbs = 0, opt_check_only_changed = 0, opt_extended = 0,
-            opt_compress = 0, opt_databases = 0, opt_fast = 0,
-            opt_medium_check = 0, opt_quick = 0, opt_all_in_1 = 0,
-            opt_silent = 0, opt_auto_repair = 0, ignore_errors = 0,
-            tty_password = 0, opt_frm = 0, debug_info_flag = 0,
-            debug_check_flag = 0, opt_fix_table_names = 0, opt_fix_db_names = 0,
-            opt_upgrade = 0, opt_write_binlog = 1;
+static bool opt_alldbs = false, opt_check_only_changed = false,
+            opt_extended = false, opt_compress = false, opt_databases = false,
+            opt_fast = false, opt_medium_check = false, opt_quick = false,
+            opt_all_in_1 = false, opt_silent = false, opt_auto_repair = false,
+            ignore_errors = false, tty_password = false, opt_frm = false,
+            debug_info_flag = false, debug_check_flag = false,
+            opt_fix_table_names = false, opt_fix_db_names = false,
+            opt_upgrade = false, opt_write_binlog = true;
 static uint verbose = 0, opt_mysql_port = 0;
 static uint opt_enable_cleartext_plugin = 0;
-static bool using_opt_enable_cleartext_plugin = 0;
+static bool using_opt_enable_cleartext_plugin = false;
 static int my_end_arg;
 static char *opt_mysql_unix_port = 0;
 static char *opt_password = 0, *current_user = 0, *current_host = 0;
@@ -296,15 +297,15 @@ static bool get_one_option(int optid, const struct my_option *opt,
       break;
     case 'C':
       what_to_do = DO_CHECK;
-      opt_check_only_changed = 1;
+      opt_check_only_changed = true;
       break;
     case 'I': /* Fall through */
     case '?':
       usage();
       exit(0);
     case 'm':
       what_to_do = DO_CHECK;
-      opt_medium_check = 1;
+      opt_medium_check = true;
       break;
     case 'o':
       what_to_do = DO_OPTIMIZE;
@@ -323,16 +324,16 @@ static bool get_one_option(int optid, const struct my_option *opt,
         opt_password = my_strdup(PSI_NOT_INSTRUMENTED, argument, MYF(MY_FAE));
         while (*argument) *argument++ = 'x'; /* Destroy argument */
         if (*start) start[1] = 0;            /* Cut length of argument */
-        tty_password = 0;
+        tty_password = false;
       } else
-        tty_password = 1;
+        tty_password = true;
       break;
     case 'r':
       what_to_do = DO_REPAIR;
       break;
     case 'g':
       what_to_do = DO_CHECK;
-      opt_upgrade = 1;
+      opt_upgrade = true;
       break;
     case 'W':
 #ifdef _WIN32
@@ -341,12 +342,12 @@ static bool get_one_option(int optid, const struct my_option *opt,
       break;
     case '#':
       DBUG_PUSH(argument ? argument : "d:t:o");
-      debug_check_flag = 1;
+      debug_check_flag = true;
       break;
 #include "sslopt-case.h"
 
     case OPT_TABLES:
-      opt_databases = 0;
+      opt_databases = false;
       break;
     case 'v':
       verbose++;
@@ -367,9 +368,9 @@ static bool get_one_option(int optid, const struct my_option *opt,
     fprintf(stderr,
             "Error:  %s doesn't support multiple contradicting commands.\n",
             my_progname);
-    return 1;
+    return true;
   }
-  return 0;
+  return false;
 }
 }
 
@@ -487,7 +488,7 @@ static int dbConnect(char *host, char *user, char *passwd) {
     DBerror(&mysql_connection, "when trying to connect");
     return 1;
   }
-  mysql_connection.reconnect = 1;
+  mysql_connection.reconnect = true;
   return 0;
 } /* dbConnect */
 

client/check/mysqlcheck_core.cc

@@ -1,5 +1,5 @@
 /*
-   Copyright (c) 2001, 2017, Oracle and/or its affiliates. All rights reserved.
+   Copyright (c) 2001, 2019, Oracle and/or its affiliates. All rights reserved.
 
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License, version 2.0,
@@ -44,12 +44,13 @@ using std::vector;
 #define KEY_PARTITIONING_CHANGED_STR "KEY () partitioning changed"
 
 static MYSQL *sock = 0;
-static bool opt_alldbs = 0, opt_check_only_changed = 0, opt_extended = 0,
-            opt_databases = 0, opt_fast = 0, opt_medium_check = 0,
-            opt_quick = 0, opt_all_in_1 = 0, opt_silent = 0,
-            opt_auto_repair = 0, ignore_errors = 0, opt_frm = 0,
-            opt_fix_table_names = 0, opt_fix_db_names = 0, opt_upgrade = 0,
-            opt_write_binlog = 1;
+static bool opt_alldbs = false, opt_check_only_changed = false,
+            opt_extended = false, opt_databases = false, opt_fast = false,
+            opt_medium_check = false, opt_quick = false, opt_all_in_1 = false,
+            opt_silent = false, opt_auto_repair = false, ignore_errors = false,
+            opt_frm = false, opt_fix_table_names = false,
+            opt_fix_db_names = false, opt_upgrade = false,
+            opt_write_binlog = true;
 static uint verbose = 0;
 static string opt_skip_database;
 int what_to_do = 0;
@@ -271,7 +272,7 @@ static void print_result() {
   char prev_alter[MAX_ALTER_STR_SIZE];
   uint i;
   size_t dot_pos;
-  bool found_error = 0, table_rebuild = 0;
+  bool found_error = false, table_rebuild = false;
 
   res = mysql_use_result(sock);
   dot_pos = strlen(sock->db) + 1;
@@ -300,8 +301,8 @@ static void print_result() {
           tables4repair.push_back(escape_db_table_name(prev, dot_pos));
         }
       }
-      found_error = 0;
-      table_rebuild = 0;
+      found_error = false;
+      table_rebuild = false;
       prev_alter[0] = 0;
       if (opt_silent) continue;
     }
@@ -316,9 +317,9 @@ static void print_result() {
       }
       if (opt_auto_repair && strcmp(row[2], "note")) {
         const char *alter_txt = strstr(row[3], "ALTER TABLE");
-        found_error = 1;
+        found_error = true;
         if (alter_txt) {
-          table_rebuild = 1;
+          table_rebuild = true;
           if (!strncmp(row[3], KEY_PARTITIONING_CHANGED_STR,
                        strlen(KEY_PARTITIONING_CHANGED_STR)) &&
               strstr(alter_txt, "PARTITION BY")) {
@@ -327,7 +328,7 @@ static void print_result() {
                   "Error: Alter command too long (>= %d),"
                   " please do \"%s\" or dump/reload to fix it!\n",
                   MAX_ALTER_STR_SIZE, alter_txt);
-              table_rebuild = 0;
+              table_rebuild = false;
               prev_alter[0] = 0;
             } else {
               strncpy(prev_alter, alter_txt, MAX_ALTER_STR_SIZE - 1);

client/dump/mysql_object_reader.cc

@@ -1,5 +1,5 @@
 /*
-  Copyright (c) 2015, 2018, Oracle and/or its affiliates. All rights reserved.
+  Copyright (c) 2015, 2019, Oracle and/or its affiliates. All rights reserved.
 
   This program is free software; you can redistribute it and/or modify
   it under the terms of the GNU General Public License, version 2.0,
@@ -79,7 +79,7 @@ bool Mysql_object_reader::Rows_fetching_context::is_all_rows_processed() {
 void Mysql_object_reader::read_table_rows_task(
     Table_rows_dump_task *table_rows_dump_task,
     Item_processing_data *item_to_process) {
-  bool has_generated_columns = 0;
+  bool has_generated_columns = false;
   Mysql::Tools::Base::Mysql_query_runner *runner = this->get_runner();
 
   if (!runner) return;
@@ -105,7 +105,7 @@ void Mysql_object_reader::read_table_rows_task(
     const Mysql::Tools::Base::Mysql_query_runner::Row &column_data = **it;
     if (column_data[1] == "STORED GENERATED" ||
         column_data[1] == "VIRTUAL GENERATED")
-      has_generated_columns = 1;
+      has_generated_columns = true;
     else
       column_names += this->quote_name(column_data[0]) + ",";
   }