Bug #30562248 ADD SUPPORT FOR GCC AND CLANG ON SOLARIS

Do not reject clang or gcc as unsupported compilers on Solaris.
Note that both compilers are experimental, and cannot currently be used
for production code.

Add misc FLAGS settings for using clang on Solaris.
It uses gcc9 libraries and headers, so we need explicit -Wl,-L... arguments.

Fix a few cmake places where we assume that SunPro is the only compiler
available on Solaris.

Silence some gcc warnings previously only relevant on Linux.

Note that clang is completely unusable at this point,
'static thread_local' variables will cause segfault during atexit processing.
There is a new test executable to prove it.

For non-trivial uses of static thread_local, the compiler will give an error:
storage/temptable/src/allocator.cc:45:32: error:
cannot compile this non-trivial TLS destruction yet
static thread_local End_thread end_thread;

gcc seems to work reasonably well on Intel, except for GIS boost code.
gcc on Sparc works OK for DEBUG builds. Non-DEBUG builds however fail
to bootstrap. The stack is garbled when handle_bootstrap() does:
    if (handler) {
      args->m_bootstrap_error = (*handler)(thd);
when called from Dictionary_impl::init() like this:
  // Creation of Data Dictionary through current server
  if (dd_init == enum_dd_init_type::DD_INITIALIZE)
    result = ::bootstrap::run_bootstrap_thread(
        nullptr, nullptr, &bootstrap::initialize, SYSTEM_THREAD_DD_INITIALIZE);

Tested with clang on Intel:
/bin/clang --version
clang version 6.0.1 (tags/RELEASE_601/final)
uname -a
SunOS xxxxxx 5.11 11.4.15.5.0 i86pc i386 i86pc

Tested with gcc on Intel and Sparc:
/usr/gcc/9/bin/gcc --version
gcc (GCC) 9.2.0
uname -a
SunOS xxxxxx 5.11 11.4.15.5.0 i86pc i386 i86pc
uname -a
SunOS xxxxxx 5.11 11.4.15.5.0 sun4v sparc sun4v

Change-Id: Ia57ef8cd6e448804ece0dbfd66da1695a8e7361f

Author: Tor Didriksen

CMakeLists.txt

@@ -400,6 +400,8 @@ IF(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
   SET(MY_COMPILER_IS_CLANG 1)
 ELSEIF(CMAKE_CXX_COMPILER_ID MATCHES "GNU")
   SET(MY_COMPILER_IS_GNU 1)
+ELSEIF(CMAKE_CXX_COMPILER_ID MATCHES "SunPro")
+  SET(MY_COMPILER_IS_SUNPRO 1)
 ENDIF()
 
 IF(MY_COMPILER_IS_CLANG OR MY_COMPILER_IS_GNU)
@@ -1296,7 +1298,8 @@ IF(NOT WITHOUT_SERVER)
   # We *could* test 'uname -v' VERSION_LESS 11.4 here.
   # A clean build takes roughly the same time with or without -xO1
   # Link time of mysqld is roughly 10% faster with -xO1.
-  IF(SOLARIS_SPARC AND CMAKE_BUILD_TYPE_UPPER STREQUAL "DEBUG")
+  IF(SOLARIS_SPARC AND MY_COMPILER_IS_SUNPRO AND
+      CMAKE_BUILD_TYPE_UPPER STREQUAL "DEBUG")
     MESSAGE(STATUS
       "Adding -xO1 for debug builds on Solaris ${MY_KERNEL_VERSION}")
     STRING_APPEND(CMAKE_CXX_FLAGS_DEBUG " -xO1")

client/CMakeLists.txt

@@ -47,7 +47,8 @@ IF(NOT WITHOUT_SERVER)
 ENDIF()
 
 # Enable inlining, to avoid stack overflow for some long regular expressions.
-IF(SOLARIS_SPARC AND CMAKE_BUILD_TYPE_UPPER STREQUAL "DEBUG")
+IF(SOLARIS_SPARC AND MY_COMPILER_IS_SUNPRO AND
+    CMAKE_BUILD_TYPE_UPPER STREQUAL "DEBUG")
   ADD_COMPILE_FLAGS(mysqltest/regular_expressions.cc
     COMPILE_FLAGS "-xO3"
     )

cmake/build_configurations/compiler_options.cmake

@@ -36,7 +36,7 @@ SET(CMAKE_POSITION_INDEPENDENT_CODE ON)
 # Compiler options
 IF(UNIX)  
 
-  IF(MY_COMPILER_IS_GNU_OR_CLANG)
+  IF(MY_COMPILER_IS_GNU_OR_CLANG AND NOT SOLARIS_SPARC)
     SET(SECTIONS_FLAG "-ffunction-sections -fdata-sections")
   ELSE()
     SET(SECTIONS_FLAG)
@@ -76,7 +76,7 @@ IF(UNIX)
     # Link mysqld with mtmalloc on Solaris 10 and later
     SET(WITH_MYSQLD_LDFLAGS "-lmtmalloc" CACHE STRING "")
 
-    IF(CMAKE_C_COMPILER_ID MATCHES "SunPro")
+    IF(MY_COMPILER_IS_SUNPRO)
       SET(SUNPRO_FLAGS     "")
       STRING_APPEND(SUNPRO_FLAGS     " -xbuiltin=%all")
       STRING_APPEND(SUNPRO_FLAGS     " -xlibmil")

cmake/googletest.cmake

@@ -207,7 +207,7 @@ IF(MY_COMPILER_IS_GNU_OR_CLANG)
     COMPILE_FLAGS "-Wno-undef -Wno-conversion")
 ENDIF()
 
-IF(SOLARIS)
+IF(MY_COMPILER_IS_SUNPRO)
   ## https://community.oracle.com/thread/4106985
   ## Assertion: (../lnk/symdescr.cc, line 96) while processing ....
   IF(NOT EXISTS ${CMAKE_BINARY_DIR}/hack/src/)
@@ -266,7 +266,7 @@ FOREACH(googletest_library
     )
 ENDFOREACH()
 
-IF(SOLARIS)
+IF(MY_COMPILER_IS_SUNPRO)
   ADD_DEFINITIONS(-DGTEST_LANG_CXX11=1)
   LIST(INSERT GMOCK_INCLUDE_DIRS 0 ${CMAKE_BINARY_DIR}/hack)
 ENDIF()

cmake/os/SunOS.cmake

@@ -47,7 +47,7 @@ CHECK_TYPE_SIZE("void *" SIZEOF_VOIDP)
 
 # We require at least SunStudio 12.6 (CC 5.15)
 IF(NOT FORCE_UNSUPPORTED_COMPILER)
-  IF(CMAKE_C_COMPILER_ID MATCHES "SunPro")
+  IF(MY_COMPILER_IS_SUNPRO)
     IF(SIZEOF_VOIDP MATCHES 4)
       MESSAGE(FATAL_ERROR "32 bit Solaris builds are not supported. ")
     ENDIF()
@@ -71,6 +71,10 @@ IF(NOT FORCE_UNSUPPORTED_COMPILER)
     IF(${CC_MINOR_VERSION} LESS 15)
       MESSAGE(FATAL_ERROR "Oracle Studio 12.6 or newer is required!")
     ENDIF()
+  ELSEIF(MY_COMPILER_IS_CLANG)
+    MESSAGE(WARNING "Clang is (highly) experimental!!")
+  ELSEIF(MY_COMPILER_IS_GNU)
+    MESSAGE(WARNING "gcc is experimental")
   ELSE()
     MESSAGE(FATAL_ERROR "Unsupported compiler!")
   ENDIF()
@@ -137,8 +141,7 @@ MACRO(DIRNAME IN OUT)
 ENDMACRO()
 
 # We assume that developer studio runtime libraries are installed.
-IF(CMAKE_SYSTEM_NAME MATCHES "SunOS" AND
-   CMAKE_CXX_COMPILER_ID STREQUAL "SunPro")
+IF(MY_COMPILER_IS_SUNPRO)
   DIRNAME(${CMAKE_CXX_COMPILER} CXX_PATH)
 
   SET(LIBRARY_SUFFIX "lib/compilers/CC-gcc/lib")
@@ -199,3 +202,39 @@ IF(CMAKE_SYSTEM_NAME MATCHES "SunOS" AND
   SET(QUOTED_CMAKE_CXX_LINK_FLAGS
     "${QUOTED_CMAKE_CXX_LINK_FLAGS} -lstatomic ")
 ENDIF()
+
+# Experimental support for clang on Intel Solaris.
+# Try to build and run static_thread_local_test.
+IF(MY_COMPILER_IS_CLANG AND SOLARIS_INTEL)
+  SET(CLANG_OUTPUT_FILE ${CMAKE_BINARY_DIR}/clang-output)
+  EXECUTE_PROCESS(
+    COMMAND ${CMAKE_CXX_COMPILER} --print-search-dirs
+    OUTPUT_FILE ${CLANG_OUTPUT_FILE}
+    )
+  FILE(READ ${CLANG_OUTPUT_FILE} OUTPUT_FILE_CONTENTS)
+  STRING(REPLACE "\n" ";" OUTPUT_FILE_CONTENTS ${OUTPUT_FILE_CONTENTS})
+  FOREACH(LINE ${OUTPUT_FILE_CONTENTS})
+    STRING(REGEX MATCH "(libraries: =)(.*)" XXX ${LINE})
+    IF(CMAKE_MATCH_1)
+      SET(LIBRARIES_STRING "${CMAKE_MATCH_2}")
+    ENDIF()
+  ENDFOREACH()
+  STRING(REPLACE ":" ";" LIBRARIES_LIST "${LIBRARIES_STRING}")
+
+  SET(LRFLAGS "")
+  FOREACH(LIB_PATH ${LIBRARIES_LIST})
+    GET_FILENAME_COMPONENT(REAL_PATH ${LIB_PATH} REALPATH)
+    STRING_APPEND(LRFLAGS " -Wl,-L${REAL_PATH} -Wl,-R${REAL_PATH}")
+  ENDFOREACH()
+
+  STRING_APPEND(CMAKE_C_LINK_FLAGS          "${LRFLAGS}")
+  STRING_APPEND(CMAKE_CXX_LINK_FLAGS        "${LRFLAGS}")
+  STRING_APPEND(CMAKE_MODULE_LINKER_FLAGS   "${LRFLAGS}")
+  STRING_APPEND(CMAKE_SHARED_LINKER_FLAGS   "${LRFLAGS}")
+
+  STRING_APPEND(CMAKE_C_LINK_FLAGS          " -lc")
+  STRING_APPEND(CMAKE_CXX_LINK_FLAGS        " -lstdc++ -lgcc_s -lc")
+  STRING_APPEND(CMAKE_MODULE_LINKER_FLAGS   " -lstdc++ -lgcc_s -lc")
+  STRING_APPEND(CMAKE_SHARED_LINKER_FLAGS   " -lstdc++ -lgcc_s -lc")
+  STRING_APPEND(QUOTED_CMAKE_CXX_LINK_FLAGS " -lstdc++ -lgcc_s -lc")
+ENDIF()

cmake/rapidjson.cmake

@@ -23,7 +23,7 @@
 # We require rapidjson version 1.1.0 or higher.
 # -DWITH_RAPIDJSON=bundled is the default
 
-IF(CMAKE_CXX_COMPILER_ID STREQUAL "SunPro")
+IF(MY_COMPILER_IS_SUNPRO)
   # Oracle Developer Studio 12.x isn't detected as c++11 compliant by rapidjson
   # automatically.
   ADD_DEFINITIONS(-DRAPIDJSON_HAS_CXX11_RANGE_FOR=1)

extra/icu/CMakeLists.txt

@@ -40,7 +40,7 @@
 
 PROJECT (ICU)
 
-IF(LINUX)
+IF(MY_COMPILER_IS_GNU_OR_CLANG)
   SET(ICU_LINUX_COMPILE_OPTIONS
     "-Wno-undef"
     "-Wno-deprecated-declarations"

extra/libevent/CMakeLists.txt

@@ -789,8 +789,8 @@ if (EVENT__BUILD_SHARED_LIBRARIES)
   set(EVENT__LIBRARY_TYPE SHARED)
 
   if (MY_COMPILER_IS_GNU_OR_CLANG)
-        add_compiler_flags(-fvisibility=hidden)
-  elseif ("${CMAKE_C_COMPILER_ID}" STREQUAL "SunPro")
+    add_compiler_flags(-fvisibility=hidden)
+  elseif (MY_COMPILER_IS_SUNPRO)
     add_compiler_flags(-xldscope=hidden)
   endif()
 

extra/protobuf/protobuf-3.6.1/cmake/CMakeLists.txt

@@ -198,6 +198,12 @@ if (protobuf_UNICODE)
   add_definitions(-DUNICODE -D_UNICODE)
 endif (protobuf_UNICODE)
 
+# Bug in std::call_once in optimized mode
+IF(SOLARIS_SPARC AND MY_COMPILER_IS_GNU AND
+    CMAKE_BUILD_TYPE_UPPER MATCHES "REL")
+  ADD_COMPILE_OPTIONS("-O0")
+ENDIF()
+
 include(libprotobuf-lite.cmake)
 include(libprotobuf.cmake)
 if (protobuf_BUILD_PROTOC_BINARIES)

mysys/CMakeLists.txt

@@ -25,7 +25,7 @@ ADD_WSHADOW_WARNING()
 SET(MY_TIME_SOURCES my_time.cc my_systime.cc)
 
 ADD_CONVENIENCE_LIBRARY(mytime ${MY_TIME_SOURCES})
-IF(SOLARIS_INTEL)
+IF(SOLARIS_INTEL AND MY_COMPILER_IS_SUNPRO)
   # Sun Studio 12.6 generates code that segfaults for std::chrono stuff.
   TARGET_COMPILE_OPTIONS(mytime_objlib PRIVATE $<$<CONFIG:RelWithDebInfo>:-xO1>)
 ENDIF()
@@ -187,10 +187,16 @@ IF(WIN32)
 ENDIF()
 
 # Bug in std::call_once in optimized mode
-IF(SOLARIS_SPARC AND MY_COMPILER_IS_GNU)
+IF(SOLARIS_SPARC AND MY_COMPILER_IS_GNU AND
+    CMAKE_BUILD_TYPE_UPPER MATCHES "REL")
   ADD_COMPILE_FLAGS(charset.cc COMPILE_FLAGS "-O0")
 ENDIF()
 
+# MD5_Init() and others are deprecated.
+IF(SOLARIS AND MY_COMPILER_IS_GNU_OR_CLANG)
+  ADD_COMPILE_FLAGS(my_md5.cc COMPILE_FLAGS "-Wno-deprecated-declarations")
+ENDIF()
+
 MYSQL_ADD_EXECUTABLE(thr_lock
   thr_lock.cc
   LINK_LIBRARIES mysys