Skip to content
This repository was archived by the owner on Apr 2, 2025. It is now read-only.

Conversation

@Andi9904
Copy link
Collaborator

With these changes, the widget is able to support the OGDF-class DynamicSPQRTree. The changes are demonstrated in the notebook SPQR-Trees.ipynb.

@Andi9904 Andi9904 requested a review from N-Coder October 11, 2022 11:12
@Andi9904 Andi9904 self-assigned this Oct 11, 2022
@N-Coder
Copy link
Owner

N-Coder commented Oct 11, 2022

Looks good to me! Two minor things I'd change before merging:

  • the force-based layout should be enabled by default for SPQR tree, the other mode doesn't really make sense here (and made me think something wasn't working at the beginning)
  • make the links between virtual dashed and maybe dark gray so that they can be differentiated from regular edges, plus they should be longer than normal edges - i.e. make their default length twice as long / attraction less strong

Things that would be nice but can also wait until after this is merged:

  • give the nodes of different skeletons different colors, e.g. all parallels yellow, circles red and rigids a random shade between green and blue (to tell adjacent rigids apart)
  • parallel edges should be spread out
  • having cluster borders drawn in would be nice (but probably also hard to do)

@N-Coder N-Coder merged commit 294b4b1 into main Oct 12, 2022
@Andi9904 Andi9904 deleted the SPQRTree branch October 13, 2022 08:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants