feat: impl From for api::Store #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-blobs/pr/169/docs/iroh_blobs/ Last updated: 2025-09-24T07:15:19Z |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, when functions want a
iroh_blobs::api::Store, and you have aMemStoreorFsStore, you have to dofs_store.as_ref().clone()to get from theFsStoreto theapi::Store. I stumbled a couple of times and had to look that up, it's not very intuitive and hard to find. So to make this easier, this addsFromimpls forapi::Storefor the various stores.Breaking Changes
Notes & open questions
Change checklist