Remove impl Deref<Blobs> for Store #173
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per rust API guidelines [0], only smart pointers should implement `Deref`. So, we remove the `impl Deref<Blobs> for Store` in this patch. [0]: https://rust-lang.github.io/api-guidelines/predictability.html?highlight=Deref#only-smart-pointers-implement-deref-and-derefmut-c-deref Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Collaborator
|
Thanks for the PR. Not quite sure how to best do this, but I think you are right that we are overusing deref. |
Author
|
I think the iroh-blobs devs came from OOP languages before implementing this codebase... (no offense of course) but in rustland we use composition over inheritance. I'd rather would like to see the whole API revamped than some half-baked "fix" for this, tbh! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #172
Description
As per rust API guidelines 0, only smart pointers should implement
Deref.So, we remove the
impl Deref<Blobs> for Storein this patch.Breaking Changes
The
impl Deref<Blobs> for Storewas removed. For all calls toStorefunctions that were referred to the underlyingBlobsinstance, useStore::blobs()to get a&Blobs.Change checklist