fix: Sender::try_send should return whether the item was sent #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rklaehn
approved these changes
May 6, 2025
Collaborator
rklaehn
left a comment
rklaehn
left a comment
There was a problem hiding this comment.
I have not yet had a case where I wanted to know if send succeeded for an ephemeral send. But since the docs say that this returns a bool, it does not hurt I guess...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inner types all support returning whether sending a message over
try_sendsucceeded or not, but the return type ofirpc::channel::spsc::Senderdidn't expose that. Fix here.