fix: build on wasm #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rklaehn
approved these changes
May 7, 2025
Collaborator
rklaehn
left a comment
rklaehn
left a comment
There was a problem hiding this comment.
Thanks a lot.
It is great not having to work on all these things alone anymore...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--no-default-features,--all-features, and default features.--no-default-features, it was broken becausen0-futurewas incorrectly listed as optional dependency (but is now always required)wasm32-unknown-unknown. I'm not 100% sure if the fix is accurate: Onmainthe build fails because a few functions that returnimpl Future + Sendfailed to build because they included an0_future::boxed::BoxFuture, which isSendon non-wasm targets only and!Sendon wasm. However I don't think it hurts for us to have those beSendon wasm as well, as we don't do anything local-only, do we? So by changing theBoxFutureto unconditionally be theSendversion, this now builds on wasm.With these changes, n0-computer/iroh-gossip#67 now compiles on wasm as well.