refactor: use adapted iroh 0rtt api #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 5, 2025
rklaehn
reviewed
Nov 5, 2025
rklaehn
approved these changes
Nov 5, 2025
Collaborator
rklaehn
left a comment
rklaehn
left a comment
There was a problem hiding this comment.
Approved since it seems the only way to work with the current iroh api, but we should revisit this soon.
github-merge-queue bot
pushed a commit
to n0-computer/iroh
that referenced
this pull request
Nov 5, 2025
## Description This allows to get hold of a future that resolves with `ZeroRttStatus` while doing work with the connection (e.g. opening streams) in parallel, without having to give up ownership of the `OutgoingZeroRttConnection`. Used in n0-computer/irpc#81 ## Breaking Changes * `OutgoingZeroRttConnection::handshake_completed()` now takes `&self` instead of `self` ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist <!-- Remove any that are not relevant. --> - [x] Self-review. - [x] Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant. - [x] Tests if relevant. - [x] All breaking changes documented. - [ ] List all breaking changes in the above "Breaking Changes" section. - [ ] Open an issue or PR on any number0 repos that are affected by this breaking change. Give guidance on how the updates should be handled or do the actual updates themselves. The major ones are: - [ ] [`quic-rpc`](https://github.com/n0-computer/quic-rpc) - [ ] [`iroh-gossip`](https://github.com/n0-computer/iroh-gossip) - [ ] [`iroh-blobs`](https://github.com/n0-computer/iroh-blobs) - [ ] [`dumbpipe`](https://github.com/n0-computer/dumbpipe) - [ ] [`sendme`](https://github.com/n0-computer/sendme) --------- Co-authored-by: “ramfox” <“kasey@n0.computer”>
ramfox
pushed a commit
that referenced
this pull request
Nov 6, 2025
Based on #81 With the 0rtt status being accessible from the connection directly, we can just move this into the `RemoteConnection` abstraction, making working with 0rtt requests simpler for implementors (see changes to the 0rtt example!).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on n0-computer/iroh#3607