Fix remote addresses in paths #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove quinn_proto::Connection::remote_address. You should use path_remote_address now. - Change quinn::Connection::remote_address to return *any* remote address from any of the open paths. - Fix opening paths on IPv4 addresses, when the endpoint supports IPv6. When the endpoint supports IPv6 it uses IPv4-mapped IPv6 addresses for IPv4 remotes. This is enforced when establishing a connection, and quinn-udp automatically does this for incoming datagrams. However when opening a path we should do the same mapping. Otherwise we will end up with an IPv4 remote address in the PathData and incoming datagrams will come from an IPv6 address and be dropped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove quinn_proto::Connection::remote_address. You should use
path_remote_address now.
Change quinn::Connection::remote_address to return any remote
address from any of the open paths.
Fix opening paths on IPv4 addresses, when the endpoint supports
IPv6.
When the endpoint supports IPv6 it uses IPv4-mapped IPv6 addresses
for IPv4 remotes. This is enforced when establishing a connection,
and quinn-udp automatically does this for incoming datagrams.
However when opening a path we should do the same mapping.
Otherwise we will end up with an IPv4 remote address in the PathData
and incoming datagrams will come from an IPv6 address and be
dropped.