Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Handle gzip and deflate compressed request payloads #7461

Merged
merged 1 commit into from
Oct 18, 2023
Merged

fix(core): Handle gzip and deflate compressed request payloads #7461

merged 1 commit into from
Oct 18, 2023

Conversation

netroy
Copy link
Member

@netroy netroy commented Oct 18, 2023

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (ef58a23) 33.50% compared to head (a522af2) 33.50%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #7461   +/-   ##
=======================================
  Coverage   33.50%   33.50%           
=======================================
  Files        3392     3392           
  Lines      207336   207345    +9     
  Branches    22374    22371    -3     
=======================================
+ Hits        69461    69467    +6     
- Misses     136747   136750    +3     
  Partials     1128     1128
Files Coverage Δ
packages/cli/src/middlewares/bodyParser.ts 93.02% <100.00%> (+1.84%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Joffcom
Joffcom approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@Joffcom Joffcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work using the reported test

@cypress
Copy link

cypress bot commented Oct 18, 2023

Passing run #2512 ↗︎

0 255 0 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project: n8n Commit: a522af242b
Status: Passed Duration: 09:48 💡
Started: Oct 18, 2023 7:08 PM Ended: Oct 18, 2023 7:18 PM

Review all test suite changes for PR #7461 ↗︎

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@netroy netroy merged commit 83762e0 into master Oct 18, 2023
56 checks passed
@netroy netroy deleted the fix-NODE-870 branch October 18, 2023 19:52
elsmr pushed a commit that referenced this pull request Oct 19, 2023
@netroy @elsmr
fix(core): Handle gzip and deflate compressed request payloads (#7461)
ae85962 
NODE-870
netroy added a commit that referenced this pull request Oct 23, 2023
@netroy
fix(core): Handle gzip and deflate compressed request payloads (#7461)
f43ff71 
NODE-870
@github-actions github-actions bot mentioned this pull request Oct 23, 2023
Merged
netroy added a commit that referenced this pull request Oct 23, 2023
@github-actions @netroy
🚀 Release 1.11.2 (#7492)
a16bc1d 
## [1.11.2](https://github.com/n8n-io/n8n/compare/n8n@1.11.1...n8n@1.11.2)
(2023-10-23)


### Bug Fixes

* **core:** Handle gzip and deflate compressed request payloads
([#7461](#7461))
([f43ff71](f43ff71))
* **core:** Prevent false stalled jobs in queue mode from displaying as
errored ([#7435](#7435))
([465a952](465a952))
* **core:** Reduce logging overhead for levels that do not output
([#7479](#7479))
([010aa57](010aa57))
* **editor:** Allow importing the same workflow multiple times
([#7458](#7458))
([33e3df8](33e3df8)),
closes [#7457](#7457)
* **editor:** Fix canvas selection breaking after interacting with node
actions ([#7466](#7466))
([90ce8de](90ce8de))
* **editor:** Fix connections disappearing after reactivating canvas and
renaming a node ([#7483](#7483))
([b0bd0d8](b0bd0d8))
* **editor:** Open only one tab with plans page
([#7377](#7377))
([d14e9cb](d14e9cb))
* **Ldap Node:** Fix issue with connections not closing correctly
([#7432](#7432))
([60ca02e](60ca02e))
* **MySQL Node:** Resolve expressions in v1
([#7464](#7464))
([2b18909](2b18909))
* **TheHive 5 Node:** Observable encoding in alert > create fix
([#7450](#7450))
([b9547ad](b9547ad))

Co-authored-by: netroy <netroy@users.noreply.github.com>
@janober
Copy link
Member

janober commented Oct 23, 2023

Got released with n8n@1.11.2

netroy added a commit that referenced this pull request Oct 23, 2023
@netroy
fix(core): Handle gzip and deflate compressed request payloads (#7461)
75981fb 
NODE-870
@github-actions github-actions bot mentioned this pull request Oct 23, 2023
Merged
netroy added a commit that referenced this pull request Oct 23, 2023
@github-actions @netroy
🚀 Release 1.12.1 (#7493)
2e79f64 
## [1.12.1](https://github.com/n8n-io/n8n/compare/n8n@1.12.0...n8n@1.12.1)
(2023-10-23)


### Bug Fixes

* **core:** Do not return `inviteAcceptUrl` in response if email was
sent ([#7465](#7465))
([4a1f4da](4a1f4da))
* **core:** Handle gzip and deflate compressed request payloads
([#7461](#7461))
([75981fb](75981fb))
* **core:** Reduce logging overhead for levels that do not output
([#7479](#7479))
([4a1641d](4a1641d))
* **Customer.io Node:** Fix api endpoint when using EU region
([#7485](#7485))
([ea1b503](ea1b503)),
closes [#7484](#7484)
* **editor:** Allow importing the same workflow multiple times
([#7458](#7458))
([15e1737](15e1737)),
closes [#7457](#7457)
* **editor:** Fix canvas selection breaking after interacting with node
actions ([#7466](#7466))
([d84c367](d84c367))
* **editor:** Fix connections disappearing after reactivating canvas and
renaming a node ([#7483](#7483))
([368e3ee](368e3ee))
* **Google Sheets Node:** Append or update runs forever when without
column headers ([#7463](#7463))
([0d52490](0d52490))
* **MySQL Node:** Resolve expressions in v1
([#7464](#7464))
([70a10a9](70a10a9))

Co-authored-by: netroy <netroy@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request Oct 25, 2023
Merged
netroy added a commit that referenced this pull request Oct 25, 2023
@github-actions @netroy
🚀 Release 1.13.0 (#7512)
2987587 
# [1.13.0](https://github.com/n8n-io/n8n/compare/n8n@1.12.0...n8n@1.13.0)
(2023-10-25)


### Bug Fixes

* **core:** Do not return `inviteAcceptUrl` in response if email was
sent ([#7465](#7465))
([55c6a1b](55c6a1b))
* **core:** Ensure nodes post-processors run in the correct order
([#7500](#7500))
([6f45298](6f45298))
* **core:** Fix `frontend.settings` external hook execution
([#7496](#7496))
([774fe20](774fe20))
* **core:** Handle gzip and deflate compressed request payloads
([#7461](#7461))
([83762e0](83762e0))
* **core:** Reduce logging overhead for levels that do not output
([#7479](#7479))
([76c0481](76c0481))
* **Customer.io Node:** Fix api endpoint when using EU region
([#7485](#7485))
([519680c](519680c))
* **editor:** Allow importing the same workflow multiple times
([#7458](#7458))
([3c0a166](3c0a166))
* **editor:** Fix canvas selection breaking after interacting with node
actions ([#7466](#7466))
([bc47365](bc47365))
* **editor:** Fix connections disappearing after reactivating canvas and
renaming a node ([#7483](#7483))
([450e0cc](450e0cc))
* **Google Sheets Node:** Append or update runs forever when without
column headers ([#7463](#7463))
([ab6a9bb](ab6a9bb))
* **Microsoft SQL Node:** Prevent SQL injection
([#7467](#7467))
([a739245](a739245))
* **MQTT Trigger Node:** Fix node causing a start up hang when active
([#7498](#7498))
([baecb93](baecb93))
* **MySQL Node:** Resolve expressions in v1
([#7464](#7464))
([5c46bb0](5c46bb0))
* **Redis Node:** Fix adding sets data types
([#7444](#7444))
([4e66023](4e66023))
* **Spreadsheet File Node:** Fix include empty cells not working with v2
([#7505](#7505))
([05e6f2a](05e6f2a))


### Features

* **core:** Add support for oauth based service accounts with UM SMTP
([#7311](#7311))
([647372b](647372b))
* **editor:** Add PH tracking to event
([#7511](#7511))
([c47d27d](c47d27d))
* **Facebook Lead Ads Trigger Node:** Add Facebook Lead Ads Trigger Node
([#7113](#7113))
([ac814a9](ac814a9))
* **Ghost Node:** Add support for lexical format
([#7488](#7488))
([7b1973c](7b1973c))
* **RSS Feed Trigger Node:** Add RSS feed trigger node
([#7386](#7386))
([689360e](689360e))

Co-authored-by: netroy <netroy@users.noreply.github.com>
mutdmour added a commit that referenced this pull request Nov 30, 2023
@mutdmour
Revert "fix(core): Handle gzip and deflate compressed request payloads (
21bec4a 
#7461)"

83762e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joffcom Joffcom Joffcom approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@netroy @janober @Joffcom