fix(Google Sheets Node): Do not insert row_number as a new column, do not checkForSchemaChanges in update operation #10201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-radency
added
n8n team
ShireenMissi
approved these changes
Jul 26, 2024
|
✅ All Cypress E2E specs passed |
1 flaky test on run #6155 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Langchain Integration > should be able to open and execute Basic LLM Chain node |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #10201 ↗︎
michael-radency
deleted the
node-1489-google-sheets-deal-gracefully-with-column-updates
branch
MiloradFilipovic
added a commit
that referenced
this pull request
Jul 29, 2024
* master: feat(HTTP Request Node): Add option to disable lowercase headers (#10154) feat: Recovery option for jsonParse helper (#10182) fix: Better error message when calling data transformation functions on a null value (#10210) refactor: Delete mistakenly commited node file (no-changelog) (#10213) refactor(editor): Add Infisical deprecation notice (#10191) feat(editor): Show new executions as `Queued` in the UI, until they actually start (#10204) refactor: Update Langchain modules & add Ollama tools support (#10208) feat(Sentiment Analysis Node): Implement Sentiment Analysis node (#10184) fix: Add original error message to messages, do not obfuscate if description provided in options (no-changelog) (#10202) fix(Google Sheets Node): Fix Google Sheet URL regex (#10195) fix(Google Sheets Node): Add column names row if sheet is empty (#10200) fix(Google Sheets Node): Do not insert row_number as a new column, do not checkForSchemaChanges in update operation (#10201) docs: Update credential urls (no-changelog) (#10193) fix(editor): Add back prompt requesting to save unsaved changes (no-changelog) (#10190) fix(HTTP Request Node): Resolve max pages expression (#10192)
cstuncsik
pushed a commit
that referenced
this pull request
Jul 31, 2024
… not checkForSchemaChanges in update operation (#10201)
Merged
|
Got released with |
cstuncsik
pushed a commit
that referenced
this pull request
Aug 1, 2024
… not checkForSchemaChanges in update operation (#10201)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
row_numbercolumn generated when reading data from sheet, if this data then used to upsert or update it would createrow_numbercolumn in sheet, we prevent this to happen when in append operation and need to do this in upsert and update as wellAfter fix we would not insert row_number as a new column, but it would still be updated or appended if sheet already has one
checkForSchemaChanges intended to prevent shifts of columns if new one was added, it should not be checked in update as it is not positional bet key: value pair based
This fix removes
checkForSchemaChangesfrom update operationRelated Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-1489/google-sheets-deal-gracefully-with-column-updates
https://linear.app/n8n/issue/NODE-1381/google-sheets-insertupsert-shouldnt-create-a-row-number-col-by-default