-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add original error message to messages, do not obfuscate if description provided in options (no-changelog) #10202
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the amount of check we have in these error classes now, we should definitely also start adding tests.
Can you please add a test that covers at least this change? We can add the rest later.
…uscation-fixes
…uscation-fixes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🙏🏽
Passing run #6157 ↗︎
Details:
Review all test suite changes for PR #10202 ↗︎ |
✅ All Cypress E2E specs passed |
* master: feat(HTTP Request Node): Add option to disable lowercase headers (#10154) feat: Recovery option for jsonParse helper (#10182) fix: Better error message when calling data transformation functions on a null value (#10210) refactor: Delete mistakenly commited node file (no-changelog) (#10213) refactor(editor): Add Infisical deprecation notice (#10191) feat(editor): Show new executions as `Queued` in the UI, until they actually start (#10204) refactor: Update Langchain modules & add Ollama tools support (#10208) feat(Sentiment Analysis Node): Implement Sentiment Analysis node (#10184) fix: Add original error message to messages, do not obfuscate if description provided in options (no-changelog) (#10202) fix(Google Sheets Node): Fix Google Sheet URL regex (#10195) fix(Google Sheets Node): Add column names row if sheet is empty (#10200) fix(Google Sheets Node): Do not insert row_number as a new column, do not checkForSchemaChanges in update operation (#10201) docs: Update credential urls (no-changelog) (#10193) fix(editor): Add back prompt requesting to save unsaved changes (no-changelog) (#10190) fix(HTTP Request Node): Resolve max pages expression (#10192)
…ription provided in options (no-changelog) (#10202)
Got released with |
…ription provided in options (no-changelog) (#10202)
Summary
add original message to messages for debugging purposes
if description provided in error that means this error was processed so do not obfuscate it
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-1528/error-obfuscation-fixes