Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add original error message to messages, do not obfuscate if description provided in options (no-changelog) #10202

Merged
merged 4 commits into from
Jul 26, 2024

Conversation

michael-radency
Copy link
Contributor

@michael-radency michael-radency commented Jul 26, 2024

Summary

add original message to messages for debugging purposes
if description provided in error that means this error was processed so do not obfuscate it

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-1528/error-obfuscation-fixes

@michael-radency michael-radency added n8n team Authored by the n8n team node/issue Issue with a node labels Jul 26, 2024
Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the amount of check we have in these error classes now, we should definitely also start adding tests.
Can you please add a test that covers at least this change? We can add the rest later.

Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏🏽

Copy link

cypress bot commented Jul 26, 2024

Passing run #6157 ↗︎

0 389 0 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Project: n8n Commit: 6c7276c155
Status: Passed Duration: 04:07 💡
Started: Jul 26, 2024 10:37 AM Ended: Jul 26, 2024 10:41 AM

Review all test suite changes for PR #10202 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@michael-radency michael-radency merged commit 512eb11 into master Jul 26, 2024
27 checks passed
@michael-radency michael-radency deleted the error-obfuscation-fixes branch July 26, 2024 11:12
MiloradFilipovic added a commit that referenced this pull request Jul 29, 2024
* master:
  feat(HTTP Request Node): Add option to disable lowercase headers (#10154)
  feat: Recovery option for jsonParse helper (#10182)
  fix: Better error message when calling data transformation functions on a null value (#10210)
  refactor: Delete mistakenly commited node file (no-changelog) (#10213)
  refactor(editor): Add Infisical deprecation notice (#10191)
  feat(editor): Show new executions as `Queued` in the UI, until they actually start (#10204)
  refactor: Update Langchain modules & add Ollama tools support (#10208)
  feat(Sentiment Analysis Node): Implement Sentiment Analysis node (#10184)
  fix: Add original error message to messages, do not obfuscate if description provided in options (no-changelog) (#10202)
  fix(Google Sheets Node): Fix Google Sheet URL regex (#10195)
  fix(Google Sheets Node): Add column names row if sheet is empty (#10200)
  fix(Google Sheets Node): Do not insert row_number as a new column, do not checkForSchemaChanges in update operation (#10201)
  docs: Update credential urls (no-changelog) (#10193)
  fix(editor): Add back prompt requesting to save unsaved changes (no-changelog) (#10190)
  fix(HTTP Request Node): Resolve max pages expression (#10192)
cstuncsik pushed a commit that referenced this pull request Jul 31, 2024
@janober
Copy link
Member

janober commented Jul 31, 2024

Got released with n8n@1.53.0

cstuncsik pushed a commit that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/issue Issue with a node Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants