-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(editor): Show new executions as Queued
in the UI, until they actually start
#10204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
Authored by the n8n team
ui
Enhancement in /editor-ui or /design-system
labels
Jul 26, 2024
netroy
force-pushed
the
PAY-1783-new-execution-status-in-UI
branch
from
July 26, 2024 09:42
096526f
to
d3e002f
Compare
alexgrozav
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 🙌
✅ All Cypress E2E specs passed |
Passing run #6158 ↗︎
Details:
Review all test suite changes for PR #10204 ↗︎ |
MiloradFilipovic
added a commit
that referenced
this pull request
Jul 29, 2024
* master: feat(HTTP Request Node): Add option to disable lowercase headers (#10154) feat: Recovery option for jsonParse helper (#10182) fix: Better error message when calling data transformation functions on a null value (#10210) refactor: Delete mistakenly commited node file (no-changelog) (#10213) refactor(editor): Add Infisical deprecation notice (#10191) feat(editor): Show new executions as `Queued` in the UI, until they actually start (#10204) refactor: Update Langchain modules & add Ollama tools support (#10208) feat(Sentiment Analysis Node): Implement Sentiment Analysis node (#10184) fix: Add original error message to messages, do not obfuscate if description provided in options (no-changelog) (#10202) fix(Google Sheets Node): Fix Google Sheet URL regex (#10195) fix(Google Sheets Node): Add column names row if sheet is empty (#10200) fix(Google Sheets Node): Do not insert row_number as a new column, do not checkForSchemaChanges in update operation (#10201) docs: Update credential urls (no-changelog) (#10193) fix(editor): Add back prompt requesting to save unsaved changes (no-changelog) (#10190) fix(HTTP Request Node): Resolve max pages expression (#10192)
cstuncsik
pushed a commit
that referenced
this pull request
Jul 31, 2024
Merged
Got released with |
cstuncsik
pushed a commit
that referenced
this pull request
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When an n8n instance hits its concurrency limits (in regular or queue mode), it starts having a delay after an execution is created and before the execution actually starts to be processed.
During this time the backend marks these executions a
new
, however the UI renders these asrunning
, which confused the users.This PRs updated the frontend to clearly distinguish between the two statuses in all execution related views.
To test this start n8n in queue mode, and do not start any workers, and create a non-manual execution (like a production webhook, or a scheduled trigger). This should create executions in the
new
state.In the workflow executions list
In the global executions list
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/PAY-1783
Review / Merge checklist