Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): Show new executions as Queued in the UI, until they actually start #10204

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

netroy
Copy link
Member

@netroy netroy commented Jul 26, 2024

Summary

When an n8n instance hits its concurrency limits (in regular or queue mode), it starts having a delay after an execution is created and before the execution actually starts to be processed.

During this time the backend marks these executions a new, however the UI renders these as running, which confused the users.

This PRs updated the frontend to clearly distinguish between the two statuses in all execution related views.

To test this start n8n in queue mode, and do not start any workers, and create a non-manual execution (like a production webhook, or a scheduled trigger). This should create executions in the new state.

In the workflow executions list

image

In the global executions list

image

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/PAY-1783

Review / Merge checklist

  • PR title and summary are descriptive
  • Tests included

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jul 26, 2024
@netroy netroy force-pushed the PAY-1783-new-execution-status-in-UI branch from 096526f to d3e002f Compare July 26, 2024 09:42
@netroy netroy requested a review from alexgrozav July 26, 2024 09:45
Copy link
Member

@alexgrozav alexgrozav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🙌

Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Jul 26, 2024

Passing run #6158 ↗︎

0 389 0 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project: n8n Commit: d3e002fe01
Status: Passed Duration: 04:08 💡
Started: Jul 26, 2024 12:08 PM Ended: Jul 26, 2024 12:12 PM

Review all test suite changes for PR #10204 ↗︎

@netroy netroy merged commit 44728d7 into master Jul 26, 2024
29 checks passed
@netroy netroy deleted the PAY-1783-new-execution-status-in-UI branch July 26, 2024 12:30
MiloradFilipovic added a commit that referenced this pull request Jul 29, 2024
* master:
  feat(HTTP Request Node): Add option to disable lowercase headers (#10154)
  feat: Recovery option for jsonParse helper (#10182)
  fix: Better error message when calling data transformation functions on a null value (#10210)
  refactor: Delete mistakenly commited node file (no-changelog) (#10213)
  refactor(editor): Add Infisical deprecation notice (#10191)
  feat(editor): Show new executions as `Queued` in the UI, until they actually start (#10204)
  refactor: Update Langchain modules & add Ollama tools support (#10208)
  feat(Sentiment Analysis Node): Implement Sentiment Analysis node (#10184)
  fix: Add original error message to messages, do not obfuscate if description provided in options (no-changelog) (#10202)
  fix(Google Sheets Node): Fix Google Sheet URL regex (#10195)
  fix(Google Sheets Node): Add column names row if sheet is empty (#10200)
  fix(Google Sheets Node): Do not insert row_number as a new column, do not checkForSchemaChanges in update operation (#10201)
  docs: Update credential urls (no-changelog) (#10193)
  fix(editor): Add back prompt requesting to save unsaved changes (no-changelog) (#10190)
  fix(HTTP Request Node): Resolve max pages expression (#10192)
cstuncsik pushed a commit that referenced this pull request Jul 31, 2024
@github-actions github-actions bot mentioned this pull request Jul 31, 2024
@janober
Copy link
Member

janober commented Jul 31, 2024

Got released with n8n@1.53.0

cstuncsik pushed a commit that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants